After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585002 - [playbin2] about-to-finish signal should block
[playbin2] about-to-finish signal should block
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 440952
 
 
Reported: 2009-06-06 15:33 UTC by Sebastian Dröge (slomo)
Modified: 2009-06-10 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2009-06-06 15:33:05 UTC
Hi,
if there's a handler for the about-to-finish signal connected it would be nice if playbin2 would block until it has returned before it goes to EOS or switches to a previously set new URI.

The reason for this is, that currently the time that is allowed for a track change in about-to-finish is quite short, see bug #440952 comment #23
Comment 1 Wim Taymans 2009-06-07 11:48:28 UTC
It does exactly that. In drained_cb it emits the signal, when that returns it tries to activate the next source, if there is no next source (because no uri was configured) it goes EOS.

For emiting the about-to-finish signal we would need to look at the duration of the file, track the position and emit the signal at duration - delay.

Am I missing something?
Comment 2 Sebastian Dröge (slomo) 2009-06-10 05:15:43 UTC
Christopher, can you explain how you used the about-to-finish signal in banshee? Did you handle the song change from the signal handler directly or did you marshal it to the main thread first and did the song change there? The latter is obviously a problem unless you're blocking the signal handler yourself ;)
Comment 3 Christopher Halse Rogers 2009-06-10 09:12:48 UTC
I was marshalling it to the main thread.  That's obviously part of the problem!  Armed with that knowledge, I'll rework the Banshee implementation.


In a related note, is there some non-source-reading documentation for playbin2? :)
Comment 4 Sebastian Dröge (slomo) 2009-06-10 10:57:03 UTC
Ok, then this bug doesn't exist ;)

And no, the only docs are gst-inspect playbin2, the sources, the docs at [0] and as examples totem and the tests/examples/$things examples that use playbin2 :)

I guess, if you have specific questions you should ask Wim :)

[0] http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-plugins/html/gst-plugins-base-plugins-playbin2.html