GNOME Bugzilla – Bug 584849
Kill warnings (uninitialized variables, strict aliasing)
Last modified: 2009-06-04 18:31:32 UTC
The attached two patches fix some warnings in gjs. The first kills a warning about "filename" being uninitialized in main() if argc == 0 -- which probably won't ever happen (outside of an embedded environment, perhaps) but is still worth fixing to quiet the warning. The second patch fixes "type punned pointer" warnings from gjs caused by failure to adhere to C99 strict aliasing rules (see http://www.cellperformance.com/mike_acton/2006/06/understanding_strict_aliasing.html)
Created attachment 135962 [details] [review] Kill-a-warning-about-uninitialized-filename-if-argc-is-0.patch
Created attachment 135963 [details] [review] Fix-strict-aliasing-errors.-Type-punned-pointer-warnings.patch
These look fine to me
Pushed, closed.