GNOME Bugzilla – Bug 584716
Use the new Empathy file transfer API
Last modified: 2009-07-29 15:21:22 UTC
Hi, a whole new API has landed now in libempathy to handle file transfer. This is incompatible with the 2.26 API, so we have to change the nautilus-sendto plugin to support it. I did it in this branch [1], which also bumps the required libempathy version accordingly. [1] http://git.collabora.co.uk/?p=user/cosimoc/nautilus-sendto.git;a=shortlog;h=refs/heads/ft_rework
The empathy plugin does not build anymore with empathy 2.27.3: empathy.c: In function 'state_changed_cb': empathy.c:156: warning: implicit declaration of function 'empathy_tp_file_get_state' empathy.c:156: warning: nested extern declaration of 'empathy_tp_file_get_state' empathy.c: In function 'send_file_cb': empathy.c:198: error: too few arguments to function 'empathy_tp_file_offer' make: *** [empathy.lo] Error 1
Could I please have a single patch attached to this bugzilla? (maintainer getting pissed off at the APIs changing all the time).
Never mind, feel free to commit, but please, next time, attach the patch to bugzilla.
Hmm, doesn't actually build. empathy.c: In function 'send_files': empathy.c:233: error: too many arguments to function 'empathy_ft_factory_new_transfer_outgoing' Full build logs with your patch: http://koji.fedoraproject.org/koji/taskinfo?taskID=1423040
Thanks for the review, I committed the patch with a trivial build fix for it. commit 258a1e1a1c8aaa8544a4f491196daf6411300c46 Author: Cosimo Cecchi <cosimo.cecchi@collabora.co.uk> Date: Fri Jun 19 21:13:27 2009 +0200 Bug 584716 – Use the new Empathy file transfer API Empathy 2.27.3 changed its file transfer API; adapt the Empathy plugin in nautilus-sendto to use it.
*** Bug 588302 has been marked as a duplicate of this bug. ***