After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584564 - Allow report renderers to return plain HTML
Allow report renderers to return plain HTML
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Reports
2.3.x
Other All
: Normal minor
: ---
Assigned To: Andreas Köhler
Andreas Köhler
Depends on:
Blocks:
 
 
Reported: 2009-06-01 22:14 UTC by Chris Dennis
Modified: 2018-06-29 22:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix bug (1.58 KB, patch)
2009-06-01 22:15 UTC, Chris Dennis
committed Details | Review

Description Chris Dennis 2009-06-01 22:14:30 UTC
Currently, report renderers (as defined by gnc:define-report) return an html-document object to the report system.  That object then may have a GnuCash 'stylesheet' applied before it is converted into HTML.  New eguile-based reports create a simple HTML string, so no further processing is required.  This fix changes report.scm so that it recognises if the report is already an HTML string and does not need further processing.

Other information:
This change does not affect existing reports, which can continue to return html-document objects as they have always done.  New reports can take advantage of the change by simply returning an HTML string instead of an html-document.  This is particularly relevant as part of the move to using Webkit instead of GTKHTML, as it allows the report to specify the <head> section and <style> elements.
Comment 1 Chris Dennis 2009-06-01 22:15:45 UTC
Created attachment 135773 [details] [review]
Patch to fix bug
Comment 2 Phil Longstaff 2009-06-02 22:30:14 UTC
Comment on attachment 135773 [details] [review]
Patch to fix bug

Committed as r18102
Comment 3 John Ralls 2018-06-29 22:22:43 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=584564. Please update any external references or bookmarks.