After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584539 - Crash in app monitor on 64 bits
Crash in app monitor on 64 bits
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-01 19:43 UTC by Milan Bouchet-Valat
Modified: 2009-06-05 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix-crash-in-app-monitor-on-64-bits-CPUs (1.34 KB, patch)
2009-06-01 19:45 UTC, Milan Bouchet-Valat 		committed Details | Review

Description Milan Bouchet-Valat 2009-06-01 19:43:04 UTC 
Dan bumped into a crash that occurs on 64 bits processors because in save_to_file(), the code assumes pointers and integers are the same size. Specifically, that's in g_hash_table_iter_next().
Comment 1 Milan Bouchet-Valat 2009-06-01 19:45:37 UTC 
Created attachment 135763 [details] [review]
Fix-crash-in-app-monitor-on-64-bits-CPUs

Hope that works...
Comment 2 Owen Taylor 2009-06-04 21:17:48 UTC 
Looks good, please go ahead and push.
Comment 3 Milan Bouchet-Valat 2009-06-05 09:25:39 UTC 
I'd just like a confirmation from Dan, because there may be other abuses of pointers that we didn't catch.
Comment 4 Dan Winship 2009-06-05 13:36:11 UTC 
sorry, yes, it's fine.

(I would have said somehting, but I could have sworn I'd seen this get committed a few days ago)
Comment 5 Milan Bouchet-Valat 2009-06-05 13:54:58 UTC 
Committed. Dear 64 bits users, come to us!