GNOME Bugzilla – Bug 583627
statistic file name needs to be standardized
Last modified: 2009-05-25 10:37:26 UTC
So trying to implement multipass encoding in Transmageddon I realized that I need to set the 'stats-file' property to the filename I want. I need to be able to set this at runtime as I don't want a hardcoded name as that risks conflicts if someone transcodes two files at the same time with two instances of transmageddon. I also need to point to a good caching directory for the temporary files. However I noticed that the ffmpeg encoders use the name 'statsfile' for the property. Since GstPresets is not useful for this as the value is not something I can set up front I suggest that the propery in x264enc gets renamed 'statsfile' so that I can use the same property call for both ffmpeg and x264 encoder and that any future encoders supporting multipass encoding get this property set to that specific value.
FWIW, I prefer stats-file to statsfile, but don't really like either very much. I would suggest adding a new property with a nice name to both, then we can just deprecate the old names (via warnings or messages or whatever). My suggestion would be: "multipass-cache-file" or somesuch.
ok, after some discussin in #gstreamer and ending up with the battle of the overkill solutions, instead of a one character fix I have decided to just work around this issue in my application.
ok, so after further discussion agreement came to that the property : multipass-cache-file should be added to both x264enc and gst-ffmpeg to allow setting this value, so re-opening the bug.
Just a small comment. To securely make temp files we probably need to use other methods, like g_mkstemp() that returns an open file descriptor. commit 43b755312bca15f74440bc1beba92c21f9ea3ccd Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Mon May 25 11:18:57 2009 +0200 x264enc: add multipass-cache-file property Fixes #583627
reopening, fix also needed for ffmpeg
commit 54273a5771c37c8b3db499479a9640ca36239f38 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Mon May 25 12:36:06 2009 +0200 enc: use standard multipass-cache-file Deprecate the old statsfile property and add a the new standard mulitpass-cache-file property to match other encoders. Fixes #583627