After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583514 - clickable URL in the About dialog
clickable URL in the About dialog
Status: VERIFIED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal trivial
: 0.13.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-22 01:04 UTC by Jean-François Fortin Tam
Modified: 2009-05-24 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
simple patch (1022 bytes, patch)
2009-05-22 01:04 UTC, Jean-François Fortin Tam
committed Details | Review

Description Jean-François Fortin Tam 2009-05-22 01:04:07 UTC
Here is a patch that makes the URL nicely clickable in all its blueness.
Comment 1 Jean-François Fortin Tam 2009-05-22 01:04:34 UTC
Created attachment 135149 [details] [review]
simple patch
Comment 2 Edward Hervey 2009-05-22 08:23:18 UTC
That patch doesn't look 100% correct. Why do you have that "from gnome import url_show" statement ? We're trying to avoid as much as possible to import gnome-specific libraries (so that non-gnome users can use pitivi).
Comment 3 Jean-François Fortin Tam 2009-05-22 14:03:04 UTC
Oops, that's an error that shouldn't have gotten there. Remove this particular line, it's useless.
Comment 4 Edward Hervey 2009-05-24 10:13:12 UTC
Simplified the patch a lot:

commit 7b0969a454caf17bbebbf6161b84bd183c4b5915
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Sun May 24 12:11:30 2009 +0200

    About: Implement clickable URL for website. Fixes #583514

diff --git a/pitivi/ui/mainwindow.py b/pitivi/ui/mainwindow.py
index c412a64..302c6a1 100644
--- a/pitivi/ui/mainwindow.py
+++ b/pitivi/ui/mainwindow.py
@@ -539,10 +539,15 @@ class PitiviMainWindow(gtk.Window, Loggable):
     def _aboutResponseCb(self, dialog, unused_response):
         dialog.destroy()
 
+    def _showWebsiteCb(self, dialog, uri):
+        import webbrowser
+        webbrowser.open_new(uri)
+
     def _aboutCb(self, unused_action):
         abt = gtk.AboutDialog()
         abt.set_name(APPNAME)
         abt.set_version("v%s" % pitivi_version)
+        gtk.about_dialog_set_url_hook(self._showWebsiteCb)
         abt.set_website("http://www.pitivi.org/")
         authors = ["Edward Hervey <bilboed@bilboed.com>",
                    "Alessandro Decina <alessandro.decina@collabora.co.uk>",
Comment 5 Jean-François Fortin Tam 2009-05-24 12:56:03 UTC
Thanks :)