After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583474 - Use named placeholders when string contains more than one
Use named placeholders when string contains more than one
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal blocker
: 0.13.2
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-21 16:45 UTC by Claude Paroz
Modified: 2009-05-29 11:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use named placeholder syntax in translatable string (1.18 KB, patch)
2009-05-21 16:46 UTC, Claude Paroz 		committed Details | Review

Description Claude Paroz 2009-05-21 16:45:49 UTC 
In Python, where a translatable string contains more than one placeholder (%s), you should always use the named syntax (%(varname)s). See following patch.
The reason is that in some languages, the apparition order of the placeholders may be inversed, hence producing an erroneous translated string.
Comment 1 Claude Paroz 2009-05-21 16:46:45 UTC 
Created attachment 135128 [details] [review]
Use named placeholder syntax in translatable string
Comment 2 Edward Hervey 2009-05-22 08:10:01 UTC 
That's a very good point... but I don't think we're going to be able to change that for the release since it would break the string freeze.

I'm putting it as a blocker for the following release (0.13.2) so we don't forget to have it fixed by then.
Comment 3 Edward Hervey 2009-05-29 11:35:03 UTC 
commit 870de46bab8b4028dafea06f64208174ea1b73f7
Author: Claude Paroz <claude@2xlibre.net>
Date:   Thu May 21 18:44:33 2009 +0200

    PluginManagerDialog: Use named placeholder. Fixes #583474