After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583367 - gstrtpL16pay ignores max-ptime property
gstrtpL16pay ignores max-ptime property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-20 20:02 UTC by Tristan Matthews
Modified: 2009-12-22 23:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Proposed patch (1.26 KB, patch)
2009-09-20 12:48 UTC, René Stadler 		none Details | Review

Description Tristan Matthews 2009-05-20 20:02:34 UTC 
Please describe the problem:
apparently, unlike other payloaders, gstrtpL16pay ignores the max-ptime setting. this setting is useful when needing to tweak latency/network usage.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Olivier Crête 2009-05-20 20:18:06 UTC 
rtpL16pay should use GstBaseRTPAudioPayload, it would gain max-ptime, etc
Comment 2 René Stadler 2009-09-20 12:48:32 UTC 
Created attachment 143524 [details] [review]
Proposed patch

It's already using BaseRTPPayload but max-ptime is only checked in is_filled, which makes no sense to use for this payloader.

This patch makes it honor max-ptime explicitely.
Comment 3 Olivier Crête 2009-09-20 16:29:33 UTC 
Maybe it could use baseaudiopayload instead.
Comment 4 Wim Taymans 2009-12-22 23:40:53 UTC 
Mistyped the bug number in the commit message.. *sigh*

commit 2ee7f58416375496c6738119465240f57c0ff9d6
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Wed Dec 23 00:38:05 2009 +0100

    rtpL16pay: convert to baseaudiopayload
    
    Use GstRTPBaseAudioPayload as the base class. This saves a lot of code and fixes
    a bunch of problems that were already solved in the base class.
    
    Fixes #853367