After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583345 - Exits when the system D-Bus daemon restarts
Exits when the system D-Bus daemon restarts
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
2.26.x
Other Linux
: Normal critical
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-20 16:21 UTC by Josselin Mouette
Modified: 2009-07-29 00:37 UTC
See Also:
GNOME target: 2.26.x
GNOME version: ---


Attachments
Do not exit when the D-Bus connection is lost (689 bytes, patch)
2009-05-21 10:47 UTC, Josselin Mouette
none Details | Review
[gsm] Do not exit when the system bus restarts (4.96 KB, patch)
2009-06-30 13:49 UTC, Vincent Untz
none Details | Review
[gsm] Do not exit when the system bus restarts (6.56 KB, patch)
2009-06-30 15:40 UTC, Vincent Untz
committed Details | Review

Description Josselin Mouette 2009-05-20 16:21:33 UTC
Whenever the system D-Bus daemon is restarted (for example when it is 
upgraded), any running gnome-session instance exits.

It doesn’t look like a crash. When attaching gdb to the process, it just 
says “Process exited with code 1”. Using breakpoints on exit() and 
_exit() doesn’t give any better results.

I’m running out of ideas on how to debug that. The issue is a bit Debian-specific since other distributions don’t restart D-Bus upon upgrades, but there are good reasons to do that, and the other GNOME programs that used to crash have been fixed.
Comment 1 Josselin Mouette 2009-05-21 10:47:57 UTC
Created attachment 135080 [details] [review]
Do not exit when the D-Bus connection is lost

Sjoerd Simmons is again the hero of the day.
Comment 2 Vincent Untz 2009-06-29 22:06:44 UTC
Hrm, shouldn't we listen to the Disconnected signal and reset some variables to NULL? Else, the GsmConsoleKit object will have some invalid references to dbus objects, won't it?
Comment 3 Vincent Untz 2009-06-30 13:49:17 UTC
Created attachment 137619 [details] [review]
[gsm] Do not exit when the system bus restarts

We also need to reconnect later to the bus.
Comment 4 Vincent Untz 2009-06-30 15:40:42 UTC
Created attachment 137631 [details] [review]
[gsm] Do not exit when the system bus restarts

Updated patch to fix a misuse of g_object_unref, and make sure we reconnect to the bus when necessary.
Comment 5 Josselin Mouette 2009-07-07 21:38:30 UTC
It seems to work fine here, thanks.
Comment 6 Vincent Untz 2009-07-29 00:37:28 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.