After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583329 - Two self tests rely on GNU iconv
Two self tests rely on GNU iconv
Status: RESOLVED INCOMPLETE
Product: glib
Classification: Platform
Component: build
2.20.x
Other NetBSD
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-05-20 12:55 UTC by Thomas Klausner
Modified: 2017-11-21 11:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Patch commenting out the two GNU iconv specific patches. (563 bytes, patch)
2009-05-20 12:56 UTC, Thomas Klausner 		rejected Details | Review

Description Thomas Klausner 2009-05-20 12:55:51 UTC 
test/convert-test.c contains two tests that rely on GNU iconv specific behaviour.
They need to be patched out on NetBSD to make the selftests succeed; the code behaves correctly.
Comment 1 Thomas Klausner 2009-05-20 12:56:31 UTC 
Created attachment 135014 [details] [review]
Patch commenting out the two GNU iconv specific patches.

NetBSD has a non-GNU iconv implementation.
Comment 2 Philip Withnall 2017-11-21 11:50:55 UTC 
Review of attachment 135014 [details] [review]:

If they don’t work on NetBSD, then I would like to see:
 - some reasoning why they don’t work on NetBSD
 - some explanation of why that’s a problem in GLib rather than a problem in iconv which should be fixed there
 - if needed, a patch which disables the tests on NetBSD only, rather than disabling them for all platforms.
Comment 3 Philip Withnall 2017-11-21 11:51:35 UTC 
Please re-open this bug report if you can provide any of that information. Thanks.