After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583283 - Shell portability in common/mkiconlinks.sh
Shell portability in common/mkiconlinks.sh
Status: RESOLVED WONTFIX
Product: gnome-themes
Classification: Deprecated
Component: General
2.26.x
Other NetBSD
: Normal normal
: ---
Assigned To: GNOME Themes Maintainers
GNOME Themes Maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2009-05-19 23:28 UTC by Thomas Klausner
Modified: 2018-08-17 19:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
Portability fix as described (471 bytes, patch)
2009-05-19 23:29 UTC, Thomas Klausner
none Details | Review

Description Thomas Klausner 2009-05-19 23:28:39 UTC
gnome-themes-2.26.1/common/mkiconlinks.sh contains unportable shell code.
Only bash's test(1) accepts two equal signs, and ${VAR:0:1} is not support by all (many?) shells. The script is started with #!/bin/sh though.

I'll attach a patch making this more portable.
Comment 1 Thomas Klausner 2009-05-19 23:29:17 UTC
Created attachment 134993 [details] [review]
Portability fix as described
Comment 2 André Klapper 2018-08-17 19:43:52 UTC
gnome-themes is not under active development anymore since 2011.
As written in https://gitlab.gnome.org/Archive/gnome-themes/commit/4df81cf0a7fd8d3da6591c4c142f47dfd7778d5f , it is obsolete.

Its codebase has been archived:
https://gitlab.gnome.org/Archive/gnome-themes/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.