After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583279 - Unportable test(1) construct in configure script
Unportable test(1) construct in configure script
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: General
2.26.x
Other NetBSD
: Normal normal
: 2.24
Assigned To: seahorse-plugins-maint
seahorse-plugins-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-19 23:14 UTC by Thomas Klausner
Modified: 2009-05-21 16:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Patch for configure as example (605 bytes, patch)
2009-05-19 23:15 UTC, Thomas Klausner 		none Details | Review
Patch for second part (376 bytes, patch)
2009-05-21 10:48 UTC, Thomas Klausner 		committed Details | Review

Description Thomas Klausner 2009-05-19 23:14:29 UTC 
The configure script uses the unportable bash "==" 
comparison operator for test(1). It is not supported by most other shells or 
even test(1) from GNU coreutils. Please use "=" instead.

I'll attach a patch against configure and leave the patch against configure.{in.ac} as an example for the reader ;)
Comment 1 Thomas Klausner 2009-05-19 23:15:15 UTC 
Created attachment 134991 [details] [review]
Patch for configure as example
Comment 2 Adam Schreiber 2009-05-20 16:14:58 UTC 
fixed in gnome-2-26 and master

commit a274fe57275269ceedbb423f18cbbce72a44e1f3
Author: Adam Schreiber <sadam@gnome.org>
Date:   Wed May 20 12:12:07 2009 -0400

    Bug 583279 – Unportable test(1) construct in configure script
    
    Changed == to = in the ebook test.
Comment 3 Thomas Klausner 2009-05-21 10:48:58 UTC 
Created attachment 135081 [details] [review]
Patch for second part

Thanks for fixing the first of the two occurrences. The attached patch (against configure.in for 2.26.2 this time) patches the second one.
Comment 4 Adam Schreiber 2009-05-21 16:50:46 UTC 
Thanks.  Committed to master and gnome-2-26.  I must have been half asleep yesterday.

commit 858307521709c39428a91ddce36cd9712d9e5360
Author: Thomas Klausner <wiz@danbala.tuwien.ac.at>
Date:   Thu May 21 12:47:34 2009 -0400

    Bug 583279 – Unportable test(1) construct in configure script
    
    Fix second test error