Bug 583274 – portability for orca script

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 583274 - portability for orca script


Summary:	portability for orca script


Status:	RESOLVED FIXED

Product:	orca
Classification:	Applications
Component:	general
Version:	2.26.x
Hardware:	Other NetBSD

Importance:	Normal normal
Target Milestone:	2.28.0
Assigned To:	Willie Walker
QA Contact:	Orca Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-05-19 22:56 UTC by Thomas Klausner
Modified:	2009-11-09 21:35 UTC

See Also:
GNOME target:	---
GNOME version:	2.25/2.26

Attachments
As described (1.07 KB, patch) 2009-05-19 22:56 UTC, Thomas Klausner	reviewed	Details \| Review

Description Thomas Klausner 2009-05-19 22:56:03 UTC

I'll attach a patch that gets rid of "<<<" in src/orca/orca.in in orca-2.26.2.
That way, non-bash shells can execute the script.

Also, the patch removes the PATH setting from this script -- why is this there?
(feel free to skip that part if there's a good reason for this)

Comment 1 Thomas Klausner 2009-05-19 22:56:50 UTC

Created attachment 134988 [details] [review]
As described

Comment 2 Willie Walker 2009-05-20 00:07:16 UTC

I'm OK with getting this into master for the 2.27.x development series.  Since mucking with the script usually ends up in failure, especially when changing shells, I'm not sure I want to do this for 2.26.  I'm also curious why has this become an issue for 2.26.2 and not 2.26.0, 2.26.1, 2.24.x.

Comment 3 Thomas Klausner 2009-05-20 00:11:23 UTC

Waiting for the next major release is fine with me.

As for your question: This was just sloppy reporting on our side -- pkgsrc uses versions of this patch since the first imported orca version, 2.18.1.

Comment 4 Willie Walker 2009-06-11 19:16:07 UTC

I left the PATH line as is because I fear changing it will break something somewhere.  But, I committed the rest of the changes to master.  Thanks Thomas!