After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 583270 - browser-plugin/totemPluginGlue.cpp uses RTLD_NODELETE without checking for it
browser-plugin/totemPluginGlue.cpp uses RTLD_NODELETE without checking for it
Status: RESOLVED INCOMPLETE
Product: totem
Classification: Core
Component: general
2.26.x
Other NetBSD
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-05-19 21:56 UTC by Thomas Klausner
Modified: 2011-04-15 12:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Suggested patch. (570 bytes, patch)
2009-05-19 21:57 UTC, Thomas Klausner 		rejected Details | Review

Description Thomas Klausner 2009-05-19 21:56:08 UTC 
In totem-2.26.2, there is the following line of code:
browser-plugin/totemPluginGlue.cpp: handle = dlopen ("libdbus-glib-1.so.2", RTLD_NOW | RTLD_NODELETE);

RTLD_NODELETE is not defined on NetBSD; defining it to 0 makes the code compile and work AFAICT.
Comment 1 Thomas Klausner 2009-05-19 21:57:23 UTC 
Created attachment 134986 [details] [review]
Suggested patch.
Comment 2 Bastien Nocera 2009-07-16 18:55:32 UTC 
Seems to me like the support is in FreeBSD:
http://www.mail-archive.com/svn-src-all@freebsd.org/msg07076.html

"Patching out" the RTLD_NODELETE flag won't have the desired effect, and might cause crashes (see the git repo for history about this problem).

I'd rather RTLD_NODELETE was checked for, and the browser-plugin not built when it's not available.
Comment 3 Bastien Nocera 2011-02-26 02:08:51 UTC 
Waiting on patch, or it didn't happen.
Comment 4 Tobias Mueller 2011-04-15 12:31:37 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!