Bug 583147 – unmatched encoder settings prevent rendering

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 583147 - unmatched encoder settings prevent rendering


Summary:	unmatched encoder settings prevent rendering


Status:	VERIFIED FIXED

Product:	pitivi
Classification:	Other
Component:	General
Version:	Git
Hardware:	Other Linux

Importance:	Normal blocker
Target Milestone:	0.13.1
Assigned To:	Pitivi maintainers
QA Contact:	Pitivi maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-05-19 01:10 UTC by Jean-François Fortin Tam
Modified:	2009-06-15 22:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Jean-François Fortin Tam 2009-05-19 01:10:26 UTC

When trying to render one of my projects in MP4 x264+AAC and setting the bitrate of the H.264 codec, I get:

Traceback (most recent call last):

+ Trace 215582

File "pitivi/ui/encodingdialog.py", line 130 in _recordButtonClickedCb
```
self.addRecordAction()
```
File "pitivi/ui/encodingdialog.py", line 182 in addRecordAction
```
self.renderaction.activate()
```
File "pitivi/action.py", line 119 in activate
```
self._ensurePipelineObjects()
```
File "pitivi/action.py", line 567 in _ensurePipelineObjects
```
self.pipeline.getBinForFactoryStream(producer, automake=True)
```
File "pitivi/pipeline.py", line 502 in getBinForFactoryStream
```
bin = stream_entry.bin = factory.makeBin(stream)
```
File "pitivi/factories/base.py", line 327 in makeBin
```
bin = self._makeBin(input_stream)
```
File "pitivi/encode.py", line 185 in _makeBin
```
rb = self.renderfactory.makeBin()
```
File "pitivi/factories/base.py", line 420 in makeBin
```
bin = self._makeBin(input_stream)
```
File "pitivi/encode.py", line 126 in _makeBin
```
b2 = EncoderFactory(setting).makeBin()
```
File "pitivi/factories/base.py", line 420 in makeBin
```
bin = self._makeBin(input_stream)
```
File "pitivi/encode.py", line 54 in _makeBin
```
enc.set_property(k, v)
```

TypeError: object of type `GstX264Enc' does not have property `quality'



I think this happens only with this particular project. Here's my guess at what happened: I initially had this project set to render to theora with a quality setting of 60 (instead of the default setting). Maybe it's trying to apply this setting to the x264 encoder and failing in the process?

Comment 1 Edward Hervey 2009-05-19 06:49:46 UTC

commit 1f4f114c2989e7f6886d3b2219c1fd71772e142c
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue May 19 08:48:40 2009 +0200

    ExportSettingsWidget: Don't return bogus element settings. Fixes #583147

Comment 2 Jean-François Fortin Tam 2009-05-19 14:25:23 UTC

A new error appears now:

Traceback (most recent call last):

+ Trace 215602

File "pitivi/ui/encodingdialog.py", line 130 in _recordButtonClickedCb
```
self.addRecordAction()
```
File "pitivi/ui/encodingdialog.py", line 182 in addRecordAction
```
self.renderaction.activate()
```
File "pitivi/action.py", line 119 in activate
```
self._ensurePipelineObjects()
```
File "pitivi/action.py", line 587 in _ensurePipelineObjects
```
self._activateLink(*link)
```

File "pitivi/action.py", line 599 in _activateLink

self.pipeline.getBinForFactoryStream(producer, prodstream)

File "pitivi/pipeline.py", line 492 in getBinForFactoryStream
```
stream, automake)
```
File "pitivi/pipeline.py", line 455 in _getStreamEntryForFactoryStream
```
raise PipelineError() pitivi.pipeline.PipelineError
```



Not sure if it's part of the same issue.

Comment 3 Edward Hervey 2009-05-19 16:34:08 UTC

not the same bug. Please open a new one and attach a PITIVI_DEBUG=5 debug log with it.