GNOME Bugzilla – Bug 583108
Song rating throught rhythmbox-client
Last modified: 2009-06-16 11:31:53 UTC
I made a patch to allow song-rating throught rhythmbox-client. usage: rhythmbox-client --rate-song X where X is a number between 0 and 5.
Created attachment 134885 [details] [review] Patch that applies to rhythmbox/remote/dbus/rb-client.c Changelog: added song rating capabilities throught rhythmbox-client
+ { "set-rating", 0, 0, G_OPTION_ARG_DOUBLE, &set_rating, N_("Rates current song"), NULL }, I think I'd prefer "Set the rating of the current song" + value=g_new0(GValue, 1); + g_value_init(value, G_TYPE_DOUBLE); + g_value_set_double(value, song_rating); Spacing is incorrect here - we generally use spaces around operators and between function names and their arguments. + if (set_rating>=0.0 && set_rating<=5.0) { and here. Other than these minor things, this looks OK to me. Generally we prefer to credit contributors by full name rather than pseudeonyms. Do you wish to be credited as 'ste' or is there a full name you'd prefer?
Created attachment 136698 [details] [review] Patch that applies to rhythmbox/remote/dbus/rb-client.c modified as suggested
I also changed my name in my account preferences :)
I cleaned up a few more things and committed it. Thanks.