After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582939 - Drop support for CDE
Drop support for CDE
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.28.x (obsolete)
Other Solaris
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-05-17 11:52 UTC by James Andrewartha
Modified: 2013-09-13 01:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
Proposed patch (45.33 KB, patch)
2009-05-18 00:50 UTC, Matthew Barnes 		committed Details | Review

Description James Andrewartha 2009-05-17 11:52:06 UTC 
shell/Makefile.am contains this:
========
install-evolution: $(install-privsolibLTLIBRARIES)
        $(mkinstalldirs) $(DESTDIR)$(bindir)
        $(LIBTOOL) --mode=install $(INSTALL_PROGRAM) evolution$(EXEEXT) $(DESTDIR)$(bindir)/evolution$(EXEEXT)

uninstall-evolution:
        $(LIBTOOL) --mode=uninstall rm -rf $(DESTDIR)$(bindir)/evolution$(EXEEXT)

if HAVE_DTAPPINTEGRATE

install-exec-local: install-evolution
        $(mkinstalldirs) $(DESTDIR)$(libexecdir)
        mv $(DESTDIR)$(bindir)/evolution-$(BASE_VERSION) $(DESTDIR)$(libexecdir)/evolution-$(BASE_VERSION)
        $(INSTALL_PROGRAM) evolution-nognome $(DESTDIR)$(bindir)/evolution-$(BASE_VERSION)

uninstall-local: uninstall-evolution
        rm -rf $(DESTDIR)$(libexecdir)/evolution-$(BASE_VERSION)
        rm -rf $(DESTDIR)$(bindir)/evolution-$(BASE_VERSION)/evolution-nognome
else

install-exec-local: install-evolution
uninstall-local: uninstall-evolution

endif
========
which is broken when HAVE_DTAPPINTEGRATE is set, as "mv $(DESTDIR)$(bindir)/evolution-$(BASE_VERSION)" fails because install-evolution installs evolution as $(DESTDIR)$(bindir)/evolution, without "-$(BASE_VERSION)".  As an alternative to fixing this, just rip out CDE (DTAPPINTEGRATE) support entirely, as even Sun doesn't use it, see the "--with-cde-path=no" in http://src.opensolaris.org/source/xref/jds/spec-files/trunk/base-specs/evolution.spec
Comment 1 Matthew Barnes 2009-05-17 13:28:46 UTC 
I think it makes sense to drop support for CDE now, especially since it was never open sourced.  It would also get rid of a lot of cruft under data/.
Comment 2 Matthew Barnes 2009-05-18 00:50:39 UTC 
Created attachment 134840 [details] [review]
Proposed patch

Patch removes all traces of CDE.  While I'm always in favor of dumping unused baggage, this is ultimately Srini's call.
Comment 3 Srinivasa Ragavan 2009-05-28 10:04:12 UTC 
Matt, I dont have an opinion here honestly. But just to avoid any unknown cases, start a thread in e-h and kick off in the code, if no response for 2 days. Thoughts?
Comment 4 Matthew Barnes 2009-05-28 13:05:28 UTC 
That sounds reasonable.  Will do.
Comment 6 Matthew Barnes 2009-06-02 16:25:08 UTC 
There were no objections, so I'm proceeding.

Patch committed to master
http://git.gnome.org/cgit/evolution/commit/?id=f2f9d1f22e3e723aa3508fa0ec91e780bbf2d3f9