After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582922 - Share timezones with other gnome apps
Share timezones with other gnome apps
Status: RESOLVED DUPLICATE of bug 559039
Product: evolution
Classification: Applications
Component: Calendar
2.26.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[cleanup]
Depends on:
Blocks:
 
 
Reported: 2009-05-17 08:43 UTC by Gil Forcada
Modified: 2010-05-22 19:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Patch to remove calendar/zones.h and update po/POTFILES.in (10.82 KB, patch)
2009-05-17 15:15 UTC, Gil Forcada 		rejected Details | Review

Description Gil Forcada 2009-05-17 08:43:44 UTC 
Currently Evolution has its own list of timezones in calendar/zones.h but maybe it makes sense to move it to e-d-s or somewhere else so if any other app needs this information it will be available for them.
Comment 1 Matthew Barnes 2009-05-17 10:28:16 UTC 
Pretty sure that file is dead and should be removed.
We use system timezones now like other apps.
Comment 2 Gil Forcada 2009-05-17 15:13:18 UTC 
I just compiled evolution-2-26 removing the calendar/zones.h file and it didn't complain, so yes we can remove it, attaching a patch.
Comment 3 Gil Forcada 2009-05-17 15:15:21 UTC 
Created attachment 134817 [details] [review]
Patch to remove calendar/zones.h and update po/POTFILES.in

Note that the patch has been done with gnome-2-26 branch I don't have installed all dependencies for master right now but should be the same, if anyone is willing to test it please :)
Comment 4 Christian Rose 2009-05-17 17:34:59 UTC 
This affects I18N, so adding that keyword.
Comment 5 Matthew Barnes 2009-05-18 01:47:58 UTC 
Patch looks fine to me, but I'll let one of the calendar guys approve it.
Comment 6 Gabor Kelemen 2009-05-18 09:26:09 UTC 
It's not surprising that the compilation does not complain, after reading this: 

- * These are the timezone names from the Olson timezone data.
- * We only place them here so gettext picks them up for translation.
- * Don't include in any C files.

Now, the next question is, where are these strings really coming from, if not from this file? In which project should we translate them?

These names are visible in several places, so I think we should find the proper place for the translations and not just throw them out.
Comment 7 Gabor Kelemen 2009-05-18 09:46:14 UTC 
After doing a bit of research, it seems that they are from glibc, but they are not translatable there.
Comment 8 Chenthill P 2009-06-03 08:48:41 UTC 
The same file exists in libical/zoneinfo/. Since libical does not have any translation in it, we would need this to be present. This is used for evolution on windows. system timezone info is not used in case of windows.
Comment 9 Matthew Barnes 2010-03-31 20:52:50 UTC 
Can this be closed or do we want to share the libical timezone translations with other apps?
Comment 10 Milan Crha 2010-04-06 12:59:24 UTC 
OK, so this is a duplicate of bug #559039, known for more than half of a year, isn't it?
Comment 11 Tobias Mueller 2010-05-22 19:20:42 UTC 
Agreed, looks like this is bug 559039 by now.

*** This bug has been marked as a duplicate of bug 559039 ***