After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582776 - empathy-2.26.1 libnotify hard dep
empathy-2.26.1 libnotify hard dep
Status: RESOLVED WONTFIX
Product: empathy
Classification: Core
Component: General
2.26.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-15 14:38 UTC by Romain Perier
Modified: 2009-05-15 14:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
empathy-2.26.1-configure-notify-option.patch (770 bytes, patch)
2009-05-15 14:40 UTC, Romain Perier
rejected Details | Review
empathy-2.26.1-client-notify-support.patch (7.91 KB, patch)
2009-05-15 14:41 UTC, Romain Perier
rejected Details | Review

Description Romain Perier 2009-05-15 14:38:35 UTC
Please describe the problem:
Hi,

libnotify is an hard dep is empathy, which could be annoying in the case where a user never uses this feature (for any reasons).
He can of course just disable it with the preferences panel, but the problem is the following : Why keep the feature in the package, increasing the binary size, and the amont of memory used at run-time, if the user will never use it ?
The more simple to everybody could be enable it if we want to use it (default behavior), or disable it explicitly otherwise. It's a important thing in gentoo community that the user has the choice, and the possibility to customize every packages.

You'll find in attachment two patches:
 - empathy-2.26.1-configure-notify-option.patch : notify support is simply non automagic
 - empathy-2.26.1-client-notify-support.patch : Add macroconstant for conditionnal compilation depending if the notify support was explicitly required or not, and patch empathy-preferences.c to hide the second page of the notebook widget if the notify support was not required.

mrpouet.



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Romain Perier 2009-05-15 14:39:36 UTC
PS: this upstream refers to https://bugs.gentoo.org/show_bug.cgi?id=269570
Comment 2 Romain Perier 2009-05-15 14:40:44 UTC
Created attachment 134708 [details] [review]
empathy-2.26.1-configure-notify-option.patch
Comment 3 Romain Perier 2009-05-15 14:41:47 UTC
Created attachment 134709 [details] [review]
empathy-2.26.1-client-notify-support.patch
Comment 4 Xavier Claessens 2009-05-15 14:45:34 UTC
I'm closing this bug WONTFIX because libnotify is an official GNOME external dep. The argument about performance is totally wrong, even with the slowest computer on earth you won't notice the different, computers does billons operations per seconds, you know ;)