After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582753 - flacdec check fails
flacdec check fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-15 11:30 UTC by Götz Waschk
Modified: 2009-05-18 12:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
debug log with debug level 5 (232.87 KB, application/x-bzip2)
2009-05-15 11:35 UTC, Götz Waschk
  Details
move audiotestsrc.flac to tests/files/, dist it, and patch flacdec unit test to find it (2.08 KB, patch)
2009-05-15 12:20 UTC, Tim-Philipp Müller
none Details | Review

Description Götz Waschk 2009-05-15 11:30:36 UTC
This is on Mandriva Cooker, gst-plugins-good 0.10.14.2 with 0c4b6ee2860e30c40f25bbb5c1c139db1eea69b7 applied:

Running suite(s): flacdec
0%: Checks: 3, Failures: 0, Errors: 3
pipelines/flacdec.c:68:E:linear:test_decode:0: (after this point) Test timeout expired
pipelines/flacdec.c:113:E:linear:test_decode_seek_full:0: (after this point) Test timeout expired
pipelines/flacdec.c:166:E:linear:test_decode_seek_partial:0: (after this point) Test timeout expired
FAIL: pipelines/flacdec
Comment 1 Götz Waschk 2009-05-15 11:35:57 UTC
Created attachment 134698 [details]
debug log with debug level 5
Comment 2 Tim-Philipp Müller 2009-05-15 12:03:02 UTC
Hrm, this doesn't look good:

filesrc gstfilesrc.c:980:gst_file_src_start:<filesrc0> opening file audiotestsrc.flac
filesrc gstfilesrc.c:1051:gst_file_src_start:<filesrc0> error: No such file "audiotestsrc.flac"

It would be good if we actually disted that file ..
Comment 3 Tim-Philipp Müller 2009-05-15 12:20:47 UTC
Created attachment 134701 [details] [review]
move audiotestsrc.flac to tests/files/, dist it, and patch flacdec unit test to find it

(We could just dist it where it is now, but I think it should go where all the other files are)
Comment 4 Tim-Philipp Müller 2009-05-15 12:22:25 UTC
Hrm, actually it is disted, but I guess the test doesn't find it for some reason.
Comment 5 Tim-Philipp Müller 2009-05-15 16:20:55 UTC
Possibly because of the two EXTRA_DIST in tests/check/Makefile.am? In any case, I've now moved the files into the right directory:

commit c014c4a621e1119ef8e2ca564de97878529b7197
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri May 15 17:11:27 2009 +0100

    checks: move files required by unit tests into tests/files and make sure they're disted
    
    Move unit test data into the directory where it belongs and make in particular
    the flacdec unit test cd into the directory with the test files instead of making
    assumptions about the current working directory in that unit test. As a side effect
    of movng those files, there's only one EXTRA_DIST in tests/check/Makefile.am now,
    which is likely to work better than having two. Hopefully fixes #582753.


Would much appreciate it if you could check with gst-plugins-good git (git://anongit.freedesktop.org/gstreamer/gst-plugins-good) that this makes things work for you. Thanks!
Comment 6 Götz Waschk 2009-05-18 12:39:11 UTC
It is fixed in 0.10.14.3.
Comment 7 Tim-Philipp Müller 2009-05-18 12:50:30 UTC
Thanks for confirming.