After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582686 - Don't g_error() when failing to release an argument
Don't g_error() when failing to release an argument
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-14 23:17 UTC by Owen Taylor
Modified: 2009-05-15 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't g_error() when failing to release an argument (2.83 KB, patch)
2009-05-14 23:17 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2009-05-14 23:17:27 UTC 
Failing to release an argument can be a symptom of bad introspection
data or other problems that aren't an internal error in gjs. Even if
it is a symptom of an internal error in gjs, propagating the exception
back gives a more meaningful failure than just aborting.
Comment 1 Owen Taylor 2009-05-14 23:17:30 UTC 
Created attachment 134674 [details] [review]
Don't g_error() when failing to release an argument
Comment 2 Havoc Pennington 2009-05-14 23:41:22 UTC 
Makes sense to me.
Comment 3 Owen Taylor 2009-05-15 15:44:47 UTC 
Pushed.