After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582656 - [mxfdemux] Fix deadlock when querying from the pad-added callback
[mxfdemux] Fix deadlock when querying from the pad-added callback
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-14 19:25 UTC by Sebastian Dröge (slomo)
Modified: 2009-05-15 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mxfdemux-deadlock.diff (15.36 KB, patch)
2009-05-14 19:25 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2009-05-14 19:25:09 UTC 
Hi,
attached patch fixes a deadlock when starting a query on mxfdemux in the pad-added callback, among other things. Tim wants this in the next release ;)
Comment 1 Sebastian Dröge (slomo) 2009-05-14 19:25:29 UTC 
Created attachment 134659 [details] [review]
mxfdemux-deadlock.diff
Comment 2 Jan Schmidt 2009-05-15 09:41:02 UTC 
beefy! Here's hoping you got it right! ;)
Comment 3 Sebastian Dröge (slomo) 2009-05-15 09:50:07 UTC 
commit f5ba4904f794a107bc5d1e56f824789bca295383
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu May 14 21:20:47 2009 +0200

    mxfdemux: Use a RW lock to protect metadata and add all pads at once without
    
    This makes it possible, among other things, to do a query in the
    pad-added callback.
    
    Fixes bug #582656.