After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582462 - souphttpsrc should set caps for "audio/L16" mime_type
souphttpsrc should set caps for "audio/L16" mime_type
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-13 12:53 UTC by Zeeshan Ali
Modified: 2009-05-21 22:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
souphttpsrc: Rename icy_caps to src_caps (2.95 KB, patch)
2009-05-20 15:04 UTC, Zeeshan Ali 		committed Details | Review
souphttpsrc: Set caps for audio/L16 content-type (2.36 KB, patch)
2009-05-20 15:04 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2009-05-13 12:53:33 UTC 
If an http server streams raw audio as described in RFC 2586[1], a decodebin2 element connected after souphttpsrc in a pipeline is unable to guess the type of media being streamed. This could be solved by adding special support for "audio/L16" mimetype: it should set the caps appropriately on the outgoing buffer(s) once it detects the said mimetype.

Will provide a patch soon since this is very important in UPnP/DLNA world where I live now a days. :)

[1] http://www.faqs.org/rfcs/rfc2586.html
Comment 1 Zeeshan Ali 2009-05-20 15:04:10 UTC 
Created attachment 135028 [details] [review]
souphttpsrc: Rename icy_caps to src_caps

Making way for next (real) patch.
Comment 2 Zeeshan Ali 2009-05-20 15:04:59 UTC 
Created attachment 135029 [details] [review]
souphttpsrc: Set caps for audio/L16 content-type

When "Content-Type" header is "audio/L16", we need to set the caps on the
outgoing buffers so that downstream elements can have means to detect the
stream type and handle it appropriately. Tested with HTTP stream provided
by pulse-audio's http module (git master).
Comment 3 Jan Schmidt 2009-05-20 15:48:07 UTC 
This seems reasonable to me
Comment 4 Zeeshan Ali 2009-05-21 20:54:45 UTC 
Should i commit?
Comment 5 Jan Schmidt 2009-05-21 21:30:54 UTC 
Fine by me, and I haven't seen anyone else objecting :)
Comment 6 Zeeshan Ali 2009-05-21 22:03:33 UTC 
(In reply to comment #5)
> Fine by me, and I haven't seen anyone else objecting :)
> 

Done! Thanks for your quick review.
Comment 7 Jan Schmidt 2009-05-21 22:33:34 UTC 
Don't forget to set your target milestone when closing bugs...