After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582420 - flacdec unit test broken on PPC
flacdec unit test broken on PPC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-13 00:10 UTC by Tim-Philipp Müller
Modified: 2009-05-13 08:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix unit test on big endian machines; fix leaks in decoder and unit test on all machines (5.29 KB, patch)
2009-05-13 00:25 UTC, Tim-Philipp Müller 		committed Details | Review

Description Tim-Philipp Müller 2009-05-13 00:10:24 UTC 
The flacdec unit test assumes samples are little endian. This will make the unit test fail on all big endian architectures. Patch will follow in a second.
Comment 1 Tim-Philipp Müller 2009-05-13 00:25:47 UTC 
Created attachment 134537 [details] [review]
Fix unit test on big endian machines; fix leaks in decoder and unit test on all machines
Comment 2 Tim-Philipp Müller 2009-05-13 08:29:44 UTC 
commit 0c4b6ee2860e30c40f25bbb5c1c139db1eea69b7
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed May 13 09:24:26 2009 +0100

    checks: fix flacdec unit tests on big-endian machines and under valgrind
    
    Flacdec outputs 16-bit samples, so let's check if the value of the first
    sample is what we expect rather than just the first byte, which may be
    different from what we expect depending on the host's endianness. Fixes
    the flacdec unit tests on PPC. Also fix a bunch of leaks in the unit
    tests to make valgrind happy. Fixes #582420.

commit 8accf2704bba2eae29874de8bb409ea67599500e
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed May 13 09:18:07 2009 +0100

    flacdec: fix buffer leak
    
    gst_buffer_replace() will take its own ref, so we still have
    to unref the buffer if we don't need it any longer.