After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582318 - Pressing panning buttons on the braille display should not interupt speech.
Pressing panning buttons on the braille display should not interupt speech.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.27.x
Other All
: Normal enhancement
: 2.28.0
Assigned To: Mesar Hameed
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-12 13:12 UTC by Mesar Hameed
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
revision 1 (1.02 KB, patch)
2009-08-06 04:36 UTC, Mesar Hameed
none Details | Review

Description Mesar Hameed 2009-05-12 13:12:32 UTC
RFE from mailing list:
http://mail.gnome.org/archives/orca-list/2009-May/msg00079.html

"I'd like to ask if there is any possibility to implement the following
functionality in orca:
Could you add an option such as when we press any button on a braille
display, it allows speech not to be interrupted? I think it is useful when
we want to read a line without speech interruption even if we press a
panning or routing cursor button during the reading process."
Comment 1 Willie Walker 2009-08-03 17:50:23 UTC
Right now, orca.py:_processBrailleEvent interrupts speech on every braille event.  We could potentially just provide a flag to determine whether or not this should be done.  I fear this might be too simple of a solution, however, and we might need to dig deeper into where the braille input is handled in the script.

Jon - is this something you can experiment with?
Comment 2 Mesar Hameed 2009-08-06 04:36:52 UTC
Created attachment 139991 [details] [review]
revision 1

Hi Will,

The attached patch seems to do it for me, does it look reasonable?

Thanks
Comment 3 Mesar Hameed 2009-08-06 04:43:18 UTC
sorry for the spam:

Mike, should speech continue even if a routing key is pressed, or only when panning keys are used.

Atm, only interupting keys on panning, since i thought routing is for editing action, and therefore speech should be interupted.

Thanks
Comment 4 Mike Pedersen 2009-08-06 19:21:20 UTC
I agree that this should be restricted to just the panning buttons.  A cursor routing button will usually move focus so should be spoken.  
Comment 5 Mesar Hameed 2009-08-08 18:18:14 UTC
Thanks Mike.

Since this is a small change, have gone ahead and commited.