After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582215 - Initialize a variable shell-app-monitor.c to fix an occasional crash
Initialize a variable shell-app-monitor.c to fix an occasional crash
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-05-11 18:15 UTC by Dan Winship
Modified: 2009-05-12 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Initialize a variable to fix an occasional crash (739 bytes, patch)
2009-05-11 18:15 UTC, Dan Winship 		none Details | Review
More complete patch, same idea (1.82 KB, patch)
2009-05-11 19:10 UTC, Milan Bouchet-Valat 		reviewed Details | Review

Description Dan Winship 2009-05-11 18:15:08 UTC 
Not sure that this is the correct fix...
Comment 1 Dan Winship 2009-05-11 18:15:10 UTC 
Created attachment 134427 [details] [review]
Initialize a variable to fix an occasional crash
Comment 2 Milan Bouchet-Valat 2009-05-11 19:10:16 UTC 
Created attachment 134433 [details] [review]
More complete patch, same idea

Good catch! Funny, I don't remember seeing this one in my tests. Now I've checked it, it should have created very bad effects all the time, and was even destroying the future handling of activities by mixing them together...

We need a little more than you fix, though: the list must be reset everytime a new activity is found in the file (which is never, for now, but I tested it anyway). And that bug was mixed with a typo (1 instead of -1) that could improve the weirdness of all that.

The attached patch should be good, at least I tested it and it fixed the testcase I could think of.
Comment 3 Dan Winship 2009-05-12 15:36:08 UTC 
looks plausible i guess...
Comment 4 Owen Taylor 2009-05-12 17:47:11 UTC 
Pushed as bea595d14391259bbabbac9285d612c19bed3a34