GNOME Bugzilla – Bug 582035
status bar misleaded by @ sign in url
Last modified: 2010-02-10 19:21:51 UTC
[ Original bug: http://bugs.debian.org/523838 ] Open the following url: https://buildd.debian.org/pkg.cgi?maint=pkg-xfce-devel@lists.alioth.debian.org Epiphany displays the following in the status bar: « Loading "lists.alioth.debian.org" » instead of buildd.debian.org. Maybe some side effects of the handling of url like http://user:pass@host/path ?
Created attachment 153430 [details] [review] Check if @ is before the first / to get the host Otherwise urls with an '@' in it after the host will wrongly report whatever is to the right of @ as the host. See the test case in the bug. Bug #582035
it looks like the patch gets all the URI punctuation correct now, though it doesn't deal with %-encoded characters ("http://gn%6Fme.org/"), which are admittedly, uncommon in hostnames. still. use SoupURI! :)
(hm... and yet, the %6F is correctly decoded in the status message, suggesting that you're parsing the string to a URI at some point, and then converting it back to a string to pass somewhere else, to then pass to ephy_string_get_host_name...)
Created attachment 153446 [details] [review] Use SoupURI to get host name in ephy-string Bug #582035 -- Thanks for the tip Dan, this makes much more sense.
Comment on attachment 153446 [details] [review] Use SoupURI to get host name in ephy-string Oh yes.
Attachment 153446 [details] pushed as fbf7c11 - Use SoupURI to get host name in ephy-string Thanks