GNOME Bugzilla – Bug 581997
Patch to support taking a series of photos
Last modified: 2009-07-29 22:32:19 UTC
This patch does the plumbing to allow cheese to take a series of photos with a delay between them. It does not provide UI configuration for the GConf keys it installs. It's based on the origin/gnome-2-24 branch in git.
Created attachment 134314 [details] [review] Allow cheese to take a series of photos.
Would it make sense to re-implement this feature as a WEBCAM_MODE_TIMELAPSE?
great work! hmm.. do you have any idea, how we could integrate this into the ui?
I was thinking that you'd take a Cheese->"timelapse photographs". This would be similar to the "Photo" or "Video" buttons on default cheese window and implemented as WEBCAM_MODE_TIMELAPSE. However, if it was undesirable to have timelapse functionality supported as a first-class citizen (as the function may be used rarely) I'd bury the options in Edit->Preferences and have the options apply to the default "Take a Photo" i.e. WEBCAM_MODE_PHOTO with repeat==true. As an intermediate option between the two, I'd implement this as Cheese->timelapse with no button on the default cheese window i.e. discoverable - but not cluttering the defaults. I'm happy to complete implementation of the feature as directed by Cheese-central. Please advise.
hehe, we do not have a cheese central ;) anyway, i think both ways are possible. would you mind to join our mailing list and propose it there? we will get a few more voices and then we can decide. sounds like a plan?
any news on this?
Sort of. I've got the following http://gitorious.org/cheese-lapse/cheese-lapse/commit/b6efbb8fd22806792ad5e394c5e7b752e5147a94 I've added a user_framerate as a "property" of the webcam. If the user does not set the framerate then the user_framerate becomes the highest_framerate, otherwise the camera captures at its native framerate but produces a video at user_framerate. I've not exposed a "Take [1 picture |V] every [1 second |V]" UI thing yet. So the user cannot currently set the user_framerate. I intend to add this to the right of the "Start recording" button. I need to do some more testing. And I need to make sure my UI modifications work on Hildon etc...
looks quite good! please go ahead ;)
Hey Aidan, could you please cook up a patch soon, because 2.28 is approaching fast and we'd love to get this in :) Thanks in advance!
I merged your main branch onto my cheese-lapse branch here http://gitorious.org/cheese-lapse/cheese-lapse/commits/cheese-lapse as *I think* I was running into the x_overlay bug. Testing required. I need to upgrade my Fedora install in order to do this.
After a little more hacking I conclude that I have no idea what I'm doing. Or at least, a have a little clue. The UI bits work. And I'm twiggiling the correct framerate settings. But both don't work together. More beer required, will get back to it tomorrow. Is there a cheese IRC channel?
no, we do not have one. but you can add me on jabber (same mail address). actually, we probably should slightly alter your idea to the following: what about taking a series of _photos_ instead of a video? as in the ui, maybe a small button on the right of the "take a photo" button would be apprpriate, where just a few options are listed, like: 3,5, 10. the time between those photos can be set then inside gconf. what do you think?
Created attachment 138412 [details] [review] Allow cheese to take a series of photos. This solves the bug in the manner that you suggest. Taking a series of photos is _much_ easier than doing a timelapse video.
I should say that this is based on today's git. And the UI may need a bit of spit and polish.
the patch works great by itself, but as you said we need to polish the ui. my first idea would be to add a small dropdown bar on the right of the "take a photo" button (but still inside the take a photo alignment box") ? do you have other ideas? thanks a lot for your great effort!
The other way I can see to do it is via the Edit->Preferences or we could have a PhotoBlast mode. Which does as you suggest. I personally don't like clogging up the default UI with a fugly spinbutton. So the PhotoBlast mode with the setting in Edit->Preferences makes sense to me.
Created attachment 139293 [details] [review] Burst mode plumbing for cheese This allows countdowns after a delay and supports full-screen.
Created attachment 139296 [details] [review] Now with added gconf schema support I forgot to modify cheese.schema.in
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Hey daniel, can you tell us the revision which made the patch? That helps for ISVs backporting the patch, finding the commited patch in case anybody wants to follow up here, etc. TIA!
the patch itself is http://git.gnome.org/cgit/cheese/commit/?id=011ee85b039d307c8b670b4238127d7817ae349f the ui of the patch is http://git.gnome.org/cgit/cheese/commit/?id=f46c5c4a653cd339b8555edcb70be7956d88f3b5 http://git.gnome.org/cgit/cheese/commit/?id=e6e217944d93dec4c61cd0d70e07b25a0222e360 http://git.gnome.org/cgit/cheese/commit/?id=2154e951c585b7ea9f05249dc8b957a47f15f917 aidan will probably add some configuration patches in the next days