After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581806 - [souphttpsrc] Should allow overriding the referer
[souphttpsrc] Should allow overriding the referer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-08 00:12 UTC by Bastien Nocera
Modified: 2009-05-08 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2009-05-08 00:12:51 UTC
Originally from:
https://bugzilla.redhat.com/show_bug.cgi?id=481405

In Totem's browser plugin, when the browser doesn't handle streaming, we should be able to pass the referer to the HTTP plugin. The easiest would probably be through an envvar, but a property would certain be cleaner (although we'd need to expose it all the way to playbin, and then inside Totem).
Comment 1 Sebastian Dröge (slomo) 2009-05-08 05:10:39 UTC
You could also iterate the sources of playbin and find the correct one and then set a property on this. I don't think it's a good idea to proxy this property from playbin but I'll add it to souphttpsrc later :)
Comment 2 Tim-Philipp Müller 2009-05-08 08:10:09 UTC
Why iterate? Isn't the notify::source callback sufficient to set this?

Comment 3 Edward Hervey 2009-05-08 08:30:32 UTC
hmm... couldn't we make this generic and have a 'extra-headers' property (of type GstStructure) where you could pass a bunch of extra http headers ? That would solve this issue amongst many others.
Comment 4 Sebastian Dröge (slomo) 2009-05-08 08:48:51 UTC
(In reply to comment #2)
> Why iterate? Isn't the notify::source callback sufficient to set this?

Right, that's even easier ;)

(In reply to comment #3)
> hmm... couldn't we make this generic and have a 'extra-headers' property (of
> type GstStructure) where you could pass a bunch of extra http headers ? That
> would solve this issue amongst many others.

Sounds good, good idea :)
Comment 5 Sebastian Dröge (slomo) 2009-05-08 09:30:47 UTC
commit 2bf3a2848b603ff6058c4061ccc0a6749a4ce199
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri May 8 11:29:04 2009 +0200

    souphttpsrc: Add support for extra-headers appended to the HTTP request
    
    This allows to set the Referer header among other things by
    adding a "extra-headers" property that takes a GstStructure
    with field=string pairs.
    
    Fixes bug #581806.