After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581756 - [id3mux] replace with something more reliable
[id3mux] replace with something more reliable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal enhancement
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-07 15:43 UTC by Tim-Philipp Müller
Modified: 2009-06-06 10:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24



Description Tim-Philipp Müller 2009-05-07 15:43:01 UTC
+++ This bug was initially created as a clone of Bug #557587 +++

> I am trying to reencode them to tagged MP3 using gst-launch.
> Conversion is done, but tags are damaged (ID3v1 contain nonsense,
> ID3v2 is not created). It happens for both ASCII and
> non-ASCII/non-ISO-8859-1 comments.
> FLAC decoder seems to work correctly.
> It sometimes crashes. If it does not crash, it creates an
> MP3 with damaged ID3 tag.

The libid3tag-based id3mux should die. We need something better.

Action plan:

 - write ID3 v2.3.0 tag writer code that doesn't depend on an
   external library (work in progress)

 - move id3mux into -good using that code base

 - merge with the taglib-based id3v2mux?
Comment 1 Michael Smith 2009-05-20 23:14:45 UTC
See bug 583383 for another id3 tag muxer that does NOT require any additional
external dependencies, supports id3v1, v2.3, and v2.4 (defaults to v1 and v2.3)
Comment 2 Tim-Philipp Müller 2009-06-06 10:22:18 UTC

commit 78ed09615b164b734f1304f3cbbc3170238dc0e7
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Jun 5 20:53:57 2009 +0100

    mad, id3mux: (re)move broken, unmaintained and unloved id3mux element

    It will be reborn with a shiny new code base under its hood in -bad.
    See #581756 and #565764.


commit 09a304b39ad5d5b692ca0893fc98c959e5a16da7
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sat Jun 6 00:39:10 2009 +0100

    id3tag: rename new id3tag element to id3mux replacing the one removed from
-ugly