After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581602 - Evolution Purge calendar function not working
Evolution Purge calendar function not working
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.26.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-05-06 14:56 UTC by Pedro Villavicencio
Modified: 2009-09-08 09:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
proposed evo patch (1.37 KB, patch)
2009-09-07 17:28 UTC, Milan Crha
committed Details | Review

Description Pedro Villavicencio 2009-05-06 14:56:51 UTC
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/evolution/+bug/372500

"
Evolution 2.26.1
Calendar
 Actions>Purge will only purge appointments defined as a recurring event.

For example;
- Add an appointment for 5 days prior to today.
- Actions>Purge to purge all events older than 0 (or 1) Days.
- Appointment not purged

Open appointment and change to recurring with 1 occurrence.
-Repeat above.
-Appointment Purged as expected."

Thanks,
Comment 1 g11024342@trbvm.com 2009-09-04 06:55:34 UTC
I can confirm this (2.26.1-0ubuntu2). This is a regression, in 2.24.x it worked.

I will try it on 2.27.91. If it's still a problem there still is some time to fix it before the 2.28 release.
Comment 2 g11024342@trbvm.com 2009-09-04 11:11:52 UTC
I have tried now, still a problem with Ubuntu's 2.27.91-0ubuntu1.

Only works for recurring events.
Comment 3 Milan Crha 2009-09-07 17:28:17 UTC
Created attachment 142633 [details] [review]
proposed evo patch

for evolution (2.27.92);

It seems the callback is called for single instances always, thus it always thinks the event shouldn't be removed. This checks also for times being passed in, and removes events as necessary.
Comment 4 g11024342@trbvm.com 2009-09-07 20:43:13 UTC
I have tested the patch and it works great! Now all my entries older than N days get removed.

If other Debian/Ubuntu-users would like to try it, this is how to do it in a simple manner:

$ sudo apt-get install build-essential fakeroot dpkg-dev
$ sudo apt-get build-dep evolution

$ mkdir ~/src
$ cd ~/src
$ apt-get source evolution
$ dpkg-source -x evolution_2*.dsc 

$ cd evolution-2*
# where cal.diff is the patch attached to this bug. you need to create that file yourself!
$ patch -p1 < gnome-cal.diff
$ dpkg-buildpackage -rfakeroot -b
$ sudo dpkg -i ../evolution_2*.deb

(HOWTO from http://www.cyberciti.biz/faq/rebuilding-ubuntu-debian-linux-binary-package/)
Comment 5 Chenthill P 2009-09-08 07:57:11 UTC
Comment on attachment 142633 [details] [review]
proposed evo patch

The patch looks good. Please commit it to stable and master
Comment 6 Milan Crha 2009-09-08 09:13:30 UTC
Created commit 6863fb0 in evo master (2.29.1+)
Created commit f61372d in evo gnome-2-28 (2.27.93+)