After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581571 - ARGB and alignment added to textrender
ARGB and alignment added to textrender
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal minor
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-06 10:02 UTC by kapil
Modified: 2009-05-07 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for ARGB and alignment added to textrender element (17.80 KB, patch)
2009-05-06 10:04 UTC, kapil 		needs-work Details | Review
Updated patch (17.66 KB, patch)
2009-05-07 13:40 UTC, kapil 		committed Details | Review

Description kapil 2009-05-06 10:02:17 UTC 
ARGB support is added to the textrender element so it can be used in case of text overlay directly performed on the hardware.
Added aligment properties like in textoverlay, to place the text at expected location.

Other information:
Comment 1 kapil 2009-05-06 10:04:05 UTC 
Created attachment 134091 [details] [review]
Patch for ARGB and alignment added to textrender element
Comment 2 Sebastian Dröge (slomo) 2009-05-07 13:06:29 UTC 
Could you split this patch into two different patches, one adding ARGB support and one adding the alignment support?

Also the changes to the AYUV rendering function look suspicious, especially the 0x80 => 255 changes.
Comment 3 kapil 2009-05-07 13:40:04 UTC 
Created attachment 134192 [details] [review]
Updated patch
Comment 4 kapil 2009-05-07 13:41:39 UTC 
Sorry did a mistake in AYUV, cahnged in updated patch. Is it really needed to split the ARGB and alignment patch ?
Comment 5 Sebastian Dröge (slomo) 2009-05-07 13:44:05 UTC 
Necessary: no :) But it would make reviewing easier... well, I'll take a close look at this later and commit it :)
Comment 6 Sebastian Dröge (slomo) 2009-05-07 14:49:15 UTC 
Thanks, committed with some minor changes...

commit e86a39cc7cf5fa53a68e2b1a5c1c9b12db22d3c2
Author: Kapil Agrawal <kapil@mediamagictechnologies.com>
Date:   Thu May 7 16:48:08 2009 +0200

    textrender: Add support for ARGB and alignment properties
    
    Fixes bug #581571.
Comment 7 Sebastian Dröge (slomo) 2009-05-07 15:40:14 UTC 
I should probably note that there were quite some bugs that I've fixed ;)