After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581444 - [multipartdemux] free memory read of buffer timestamp
[multipartdemux] free memory read of buffer timestamp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-05 11:05 UTC by Arnout Vandecappelle
Modified: 2009-05-05 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[multipartdemux] Don't read from the incoming buffer after flushing the adapter (1.15 KB, patch)
2009-05-05 11:07 UTC, Arnout Vandecappelle 		committed Details | Review

Description Arnout Vandecappelle 2009-05-05 11:05:25 UTC 
Multipartdemux sets the timestamp of the output buffer to the timestamp of the incoming buffer after flushing the adapter.  The flush may have freed the incoming buffer (as far as I understand...).

Patch follows.
Comment 1 Arnout Vandecappelle 2009-05-05 11:07:24 UTC 
Created attachment 134014 [details] [review]
[multipartdemux] Don't read from the incoming buffer after flushing the adapter
Comment 2 Wim Taymans 2009-05-05 15:14:01 UTC 
commit e0099bbeb20528e8241d64fca8eb6abd7e5b5b93
Author: Arnout Vandecappelle <arnout@mind.be>
Date:   Tue May 5 17:07:13 2009 +0200

    multipartdemux: avoid reading from invalid memory
    
    Read the timestamp of the incomming buffer before we push it in the adapter and
    flush it out again as the buffer might be unreffed then and we read from invalid
    memory.
    Fixes #581444.