After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581349 - Gio::File::load_contents() should allow not requesting etag
Gio::File::load_contents() should allow not requesting etag
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: giomm
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2009-05-04 18:23 UTC by Hubert Figuiere (:hub)
Modified: 2009-06-18 03:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (9.50 KB, patch)
2009-05-04 18:28 UTC, Hubert Figuiere (:hub) 		none Details | Review
patch (10.31 KB, patch)
2009-06-17 21:17 UTC, Hubert Figuiere (:hub) 		committed Details | Review

Description Hubert Figuiere (:hub) 2009-05-04 18:23:20 UTC 
Gio::File::load_contents() (and al.) should allow not requesting etag.

Will attach a patch.
Comment 1 Hubert Figuiere (:hub) 2009-05-04 18:28:56 UTC 
Created attachment 133945 [details] [review]
patch
Comment 2 Hubert Figuiere (:hub) 2009-06-17 21:17:05 UTC 
Created attachment 136872 [details] [review]
patch

updated with danielk feedback
Comment 3 Jonathon Jongsma 2009-06-18 03:25:30 UTC 
I hate that we need to provide all of these overloaded functions for arguments, but that has nothing to do with your patch.  the patch looks fine.  please commit.
Comment 4 Hubert Figuiere (:hub) 2009-06-18 03:33:21 UTC 
thanks a lot. fixed.

and yes I agree we could make that easier. For glibmm3 :-)