After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581341 - [lamemp3enc] doesn't build with LAME 3.97: implicit declaration of function ‘lame_set_VBR_quality’
[lamemp3enc] doesn't build with LAME 3.97: implicit declaration of function ‘...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-04 17:47 UTC by Tristan Matthews
Modified: 2009-05-05 15:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available (1023 bytes, patch)
2009-05-04 19:42 UTC, Tim-Philipp Müller
none Details | Review
possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available (this time for real) (987 bytes, patch)
2009-05-05 00:02 UTC, Tim-Philipp Müller
none Details | Review
output of grep for LAME_CFLAGS etc. (2.10 KB, text/plain)
2009-05-05 15:10 UTC, Tristan Matthews
  Details
output of grep for LAME_CFLAGS etc. (925 bytes, text/plain)
2009-05-05 15:15 UTC, Tristan Matthews
  Details
possible fix: third attempt (973 bytes, patch)
2009-05-05 15:28 UTC, Tim-Philipp Müller
committed Details | Review

Description Tristan Matthews 2009-05-04 17:47:37 UTC
Please describe the problem:
Building gst-plugins-ugly fails with:
  CC    gstlamemp3enc.o
cc1: warnings being treated as errors
gstlamemp3enc.c: In function ‘gst_lamemp3enc_setup’:
gstlamemp3enc.c:771: warning: implicit declaration of function ‘lame_set_VBR_quality’
make[3]: *** [libgstlame_la-gstlamemp3enc.lo] Error 1


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
I believe this is the changeset that caused this behaviour:
http://cgit.freedesktop.org/gstreamer/gst-plugins-ugly/commit/?id=1dcdac76299b73965fe23e6b4d57dddb002f7a44
Comment 1 Tim-Philipp Müller 2009-05-04 18:36:13 UTC
What version of lame do you have? Presumably something < 3.98?
Comment 2 Tristan Matthews 2009-05-04 19:33:17 UTC
i have lame 3.97 (package from Hardy)
Comment 3 Tim-Philipp Müller 2009-05-04 19:42:51 UTC
Created attachment 133953 [details] [review]
possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available

Does this fix it for you?
Comment 4 Tristan Matthews 2009-05-04 20:00:29 UTC
i applied the patch but it's still not getting that function definition:
  CC    gstlamemp3enc.o
cc1: warnings being treated as errors
gstlamemp3enc.c: In function ‘gst_lamemp3enc_setup’:
gstlamemp3enc.c:776: warning: implicit declaration of function ‘lame_set_VBR_quality’
Comment 5 Tim-Philipp Müller 2009-05-04 21:41:32 UTC
Was configure.ac updated and did configure re-run?
Comment 6 Tristan Matthews 2009-05-04 23:26:15 UTC
yeah the changes are there, i ran
make distclean && ./autogen.sh && ./configure && make && sudo make install
to no avail
Comment 7 Tim-Philipp Müller 2009-05-05 00:02:42 UTC
Created attachment 133980 [details] [review]
possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available (this time for real)

Let's try this again ...
Comment 8 Tristan Matthews 2009-05-05 00:33:18 UTC
still doesn't work, same error as before.
Comment 9 Tim-Philipp Müller 2009-05-05 07:59:43 UTC
Ok, so:

 - what's the output of 'grep LAME_CFLAGS Makefile' ?

 - what's the output of

   grep -A 200 lame_init config.log  | grep -B 200 'These plugins will be built: lame'

   (as attachement if too long please)

Comment 10 Tristan Matthews 2009-05-05 15:10:36 UTC
Created attachment 134027 [details]
output of grep for LAME_CFLAGS etc.
Comment 11 Tristan Matthews 2009-05-05 15:15:14 UTC
Created attachment 134028 [details]
output of grep for LAME_CFLAGS etc.

the last one wasn't correct
Comment 12 Tim-Philipp Müller 2009-05-05 15:28:55 UTC
Created attachment 134030 [details] [review]
possible fix: third attempt
Comment 13 Tristan Matthews 2009-05-05 15:33:11 UTC
That did it.
Comment 14 Tim-Philipp Müller 2009-05-05 15:46:02 UTC
commit 95ddda57e2f5ac2b52fb4431e739cceba5a20722
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue May 5 16:38:19 2009 +0100

    lame: fix compilation with LAME versions < 3.98
    
    lame_set_VBR_quality(), which takes a floating point value for the
    quality, has been added only in v3.98. Use lame_set_VBR_q(), which
    takes quality as an integer, for older LAME versions.
    
    Fixes #581341.