GNOME Bugzilla – Bug 581341
[lamemp3enc] doesn't build with LAME 3.97: implicit declaration of function ‘lame_set_VBR_quality’
Last modified: 2009-05-05 15:46:02 UTC
Please describe the problem: Building gst-plugins-ugly fails with: CC gstlamemp3enc.o cc1: warnings being treated as errors gstlamemp3enc.c: In function ‘gst_lamemp3enc_setup’: gstlamemp3enc.c:771: warning: implicit declaration of function ‘lame_set_VBR_quality’ make[3]: *** [libgstlame_la-gstlamemp3enc.lo] Error 1 Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information: I believe this is the changeset that caused this behaviour: http://cgit.freedesktop.org/gstreamer/gst-plugins-ugly/commit/?id=1dcdac76299b73965fe23e6b4d57dddb002f7a44
What version of lame do you have? Presumably something < 3.98?
i have lame 3.97 (package from Hardy)
Created attachment 133953 [details] [review] possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available Does this fix it for you?
i applied the patch but it's still not getting that function definition: CC gstlamemp3enc.o cc1: warnings being treated as errors gstlamemp3enc.c: In function ‘gst_lamemp3enc_setup’: gstlamemp3enc.c:776: warning: implicit declaration of function ‘lame_set_VBR_quality’
Was configure.ac updated and did configure re-run?
yeah the changes are there, i ran make distclean && ./autogen.sh && ./configure && make && sudo make install to no avail
Created attachment 133980 [details] [review] possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available (this time for real) Let's try this again ...
still doesn't work, same error as before.
Ok, so: - what's the output of 'grep LAME_CFLAGS Makefile' ? - what's the output of grep -A 200 lame_init config.log | grep -B 200 'These plugins will be built: lame' (as attachement if too long please)
Created attachment 134027 [details] output of grep for LAME_CFLAGS etc.
Created attachment 134028 [details] output of grep for LAME_CFLAGS etc. the last one wasn't correct
Created attachment 134030 [details] [review] possible fix: third attempt
That did it.
commit 95ddda57e2f5ac2b52fb4431e739cceba5a20722 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Tue May 5 16:38:19 2009 +0100 lame: fix compilation with LAME versions < 3.98 lame_set_VBR_quality(), which takes a floating point value for the quality, has been added only in v3.98. Use lame_set_VBR_q(), which takes quality as an integer, for older LAME versions. Fixes #581341.