After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 581333 - rtspsrc: request_pt_map in gstrtspsrc.c fails to return correct pt caps under ARM
rtspsrc: request_pt_map in gstrtspsrc.c fails to return correct pt caps under...
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.15
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-05-04 16:35 UTC by Chris Winter
Modified: 2010-04-03 17:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Fix for bug 581333 (508 bytes, patch)
2009-05-04 16:39 UTC, Chris Winter
none Details | Review

Description Chris Winter 2009-05-04 16:35:56 UTC
Please describe the problem:
My original report of this bug can be found here on the gstreamer-devel mailing list:

http://sourceforge.net/mailarchive/message.php?msg_name=212bfead0904301134s647db708s6457040d00625b65%40mail.gmail.com

Summary: Under ARM, request_pt_map fails to return the correct pt caps.

Steps to reproduce:
Attempt to play the following gst-launch pipeline on an ARM-based platform:

gst-launch rtspsrc location="rtsp://ewan.rtsp-youtube.l.google.com/CkELENy73wIaOAkNHBGWSDl4oBMYESARFEIJbXYtZ29vZ2xlSARSBXdhdGNoWglDbGlja0xpbmtgqqug0Nj3uroLDA==/0/0/0/video.3gp" name=d d. ! rtpmp4adepay ! fakesink d. ! rtpmp4vdepay ! fakesink

Actual results:
The pipeline errors out internally and fails to process the incoming RTP data stream.

Expected results:
The pipeline processes the RTP data stream correctly, and audio/video can be heard/seen.

Does this happen every time?
Yes.

Other information:
My original report to gstreamer-devel had an extensive log from GST_DEBUG attached.
Comment 1 Chris Winter 2009-05-04 16:39:37 UTC
Created attachment 133932 [details] [review]
Fix for bug 581333

This patch fixes the observed problem on my ARM platform (basically, a beagleboard running openembedded). I have tested it also on a Fedora 10 desktop with gstreamer git (which plays rtsp streams correctly even without this patch), and there was no loss in functionality.
Comment 2 Wim Taymans 2009-05-04 16:47:25 UTC
Any idea if this is caused by the fact that the session id passed in the signal callback is always the same or if the GINT_TO_POINTER()/GPOINTER_TO_INT() macros mess things up?

My thinking is that we should not use those macros but pass the pointer to the int instead.
Comment 3 Wim Taymans 2009-05-04 16:57:27 UTC
Can you see that this fix also solves the problem? If it does not, please reopen this bug.

commit 732704c007f6119010fdace995ce246b10ba9f91
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon May 4 18:55:12 2009 +0200

    rtspsrc: Fix find_stream_by_* functions
    
    Fix various version of find_stream_by_* by not trying to convert an int to a
    pointer and vice versa, for portability reasons.
    
    Fixes #581333
Comment 4 Chris Winter 2009-05-04 17:13:40 UTC
Unfortunately, your fix does not solve the problem.

To answer your question from comment #2, I can see that the session id being passed in is the same for both payload type caps queries. On my Fedora 10 desktop build of gstreamer git, I see different session ids.

If you feel that this is more the cause of the problem, and that my original proposed fix is only taking care of a symptom, then I'd be happy to dig around some more to figure out why the session ids are the same. Does gstrtpbin handle all that -- is that where I should start looking?
Comment 5 Wim Taymans 2009-05-05 17:28:51 UTC
I would think the root problem is somewhere in gstrtpbin, yes.
Comment 6 Wim Taymans 2009-05-05 17:36:56 UTC
a debug log like this could be useful:

  GST_DEBUG=*rtp*:5 <appname> >debug.log 2>&1

and then compress the resulting debug.log and attach here.
Comment 7 Tim-Philipp Müller 2009-06-15 20:19:38 UTC
Chris: ping?
Comment 8 Tobias Mueller 2010-04-03 17:56:05 UTC
Chris, please reopen this bug report if you have any news. Thanks in advance.