GNOME Bugzilla – Bug 581018
Mass Storage only supports USB devices
Last modified: 2020-03-17 08:29:00 UTC
Please describe the problem: I have an integrated SD card reader in my laptop (Lenovo t61p). If I create a .is_audio_player file rhythmbox will correctly enumerate the device as an audio device, but banshee will not. It appears this is because MS mode for banshee only works with USB devices, and makes all kinds of assumptions in getting device info from that. It would be really ideal if this worked for integrated readers as well so that I don't need a USB card reader to get banshee to sync on my laptop which has integrated SD reader. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
I've made a first attempt at fixing this in this github tree (a fork of stable) - http://github.com/sdague/banshee/tree/stable The basic changes are: * even if a device is not usb, if it contains .is_audio_player pass, let the device be registered * build the UsbDevice even if it has no usb ids * a try / catch around the Custom Device lookup, which does that by usb ids At that point I end up being able to stick my SD card in the integrated reader and have it show up in Banshee and podcast sync worked. The patch also includes debugging as I was looking for better properties to match on. It's a bit hackish to just brute force the device in as a "USB Device", but it works surprisingly well, as the USB aspects of the device don't seem to be used much. The device name in Banshee is "Computer", which comes out of HAL. It would be nice to get that to be something more reasonable. Not sure how to tackle that.
Hi Sean, thanks for working on this. Does your device have a vendor/product id, even though it's obviously not USB? I'm wondering if we could change the current, usb-spedific, vendor/product-ids-are-shorts code into something more generic - maybe just strings for them. Can you paste or attach the hal-device output for your device (and its parents/children)?
Can you give me a command I should run, or which output you'd like to get this? My familiarity with hal internals is low. Thanks
You can just attach the full results of hal-device
Ideally while you have a sd card inserted and mounted
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
*** Bug 632819 has been marked as a duplicate of this bug. ***
A solution for this would be great. Syncing via USB works most of the time, but just putting the flash card into the PC and being able to do the same thing would be really nice. Sometimes just copying by hand the media is not enough, for example in cases where certain file names or codecs are unsupported. I haven't tried the .is_audio_player thing. Would it overwrite the settings that banshee uses in situations where I connect via android phone/USB?
Personally, I would also like this solution to be possible for NFS drives. That way I can use NFS to treat my Eee PC as an "audio device" and automatically load it with music and playlists.
Sean, can you provide the information asked in comment#3? Also, if you could post a diff with the differences between your fork and current Banshee, that would be great.
I meant, comment#4 :)
While this is still probably a worth while fix, I stopped using banshee a couple of years back. So it's probably worth closing the bug unless someone else is interested in it.
Well, it's still a valid thing to implement, and you're not the only user that requested it (see comment#9), so I guess the bug can remain open. That being said, I just realised that there is an extension in the Banshee-Community-Extensions repository that may actually provide this feature, it's called "DirectorySync" if I recall correctly.
*** Bug 672005 has been marked as a duplicate of this bug. ***
Created attachment 209637 [details] [review] handle non usb mass storage devices Patch from the duplicate, by Fabrice Bellet
Created attachment 210865 [details] [review] Updated patch to handle non-usb mass storage devices The DeviceMapper.Map() method should be called, even when no usb device is found.
What do we need to commit this patch? Timo have ever modify it on his own mac build and I think it is better.
*** Bug 723572 has been marked as a duplicate of this bug. ***
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.