After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580957 - Change the way we trigger a warning in testDebugger
Change the way we trigger a warning in testDebugger
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-30 23:28 UTC by Owen Taylor
Modified: 2009-05-05 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change the way we trigger a warning in testDebugger (1.11 KB, patch)
2009-04-30 23:28 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2009-04-30 23:28:48 UTC 
let x = <something undefined> doesn't seem to trigger a warning
(and our error hook) with xulrunner-1.9.1, so switch to
new String(<something undefined>).
Comment 1 Owen Taylor 2009-04-30 23:28:51 UTC 
Created attachment 133709 [details] [review]
Change the way we trigger a warning in testDebugger
Comment 2 Havoc Pennington 2009-05-05 20:19:10 UTC 
can't explain this, but looks fine if it works
Comment 3 Owen Taylor 2009-05-05 20:26:12 UTC 
If you look at the code in spidermonkey that determines when to warn on undefined properties, it's incredibly heuristic and not very deterministic. So it doesn't surprise me that it changed between xulrunner 1.9.0 and 1.9.1 or whatever.

Pushed.