GNOME Bugzilla – Bug 580946
Should not use deprecated gtk symbols
Last modified: 2009-05-03 19:06:39 UTC
The following deprecated gtk symbols are found in the source of gtkhtml: gtk_signal_connect gtk_action_connect_proxy gtk_box_pack_start_defaults
Created attachment 133694 [details] [review] Replace deprecated gtk symbol The patch replaces the deprecated api and bumps gtk dep to 2.16
Created attachment 133702 [details] [review] Replace deprecated gtk symbol (v2) Whoops. That was a bad patch. This one is the same but without me being stupid. Sorry
I definitely do expect those gtkhtml maintainers that work for Novell to refuse a patch that bumps the GTK+ requirement to 2.16 because Novell *managers* will bitch about this, driven by the stupid idea to be able to ship a more recent Evolution version for some ancient stone-aged GNOME versions included in their SLED-whatever. This blocks progress in GNOME, is quite selfish of Novell (taking upstream GNOME as a hostage just because Novell is too lazy to manage their own patchsets against upstream internally) and shows missing understanding of the GNOME concept (the synchronized version numbers exist for a reason - Evolution 2.26 should never be meant to run on GNOME 2.22). Hence I should maybe just commit this.
wow, this really sucks. I'll provide yet another ifdef-based patch then. The code will be a bit more messy but that is not my headache.
Great. Looks like the situation changed. Big thanks to Novell. --> Commit to master. :)
Yep, I was about to comment that.
Committed to master: http://git.gnome.org/cgit/gtkhtml/commit/?id=c77b34e4904dc729a0cf2267dcd0a00c93c1acd5