After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580904 - Kill libgnome(ui) dependency
Kill libgnome(ui) dependency
Status: RESOLVED FIXED
Product: Evolution Exchange
Classification: Deprecated
Component: Connector
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: Connector Maintainer
Ximian Connector QA
Depends on:
Blocks:
 
 
Reported: 2009-04-30 15:44 UTC by André Klapper
Modified: 2009-08-24 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Looks like two headers are not needed anyway (351 bytes, patch)
2009-07-18 14:39 UTC, André Klapper
committed Details | Review
proposed eex patch (34.05 KB, patch)
2009-08-19 10:08 UTC, Milan Crha
committed Details | Review

Description André Klapper 2009-04-30 15:44:01 UTC
No idea if evo-mapi will have feature parity with e-e for 2.29.
In case it won't have, please fix:

http://live.gnome.org/LibgnomeMustDie


$:andre\> grep -r "include <libgnome" .
./storage/migr-test.c:#include <libgnomeui/gnome-app.h>
./storage/migr-test.c:#include <libgnomeui/gnome-ui-init.h>
./storage/migr-test.c:#include <libgnome/libgnome.h>
./storage/ximian-connector-setup.c:#include <libgnomeui/gnome-ui-init.h>
./storage/main.c:#include <libgnomeui/gnome-ui-init.h>
./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid.h>
./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid-page-standard.h>

Also see bug 580887 for evolution and its subbugs.

PS: e-e is missing version 2.26 in this bugzilla. Please create.
Comment 1 Matthew Barnes 2009-04-30 16:38:43 UTC
GnomeDruid will be fun.  The rest should be easy.
Comment 2 André Klapper 2009-07-18 14:39:28 UTC
Created attachment 138672 [details] [review]
Looks like two headers are not needed anyway
Comment 3 André Klapper 2009-07-18 17:33:53 UTC
Heja abharath!
Asking for a quick review and test of the patch here.
Cleans up our GNOME3 readiness statistics a bit...

Do you plan to work on the rest of the issues soon?
Except for GnomeDruid this should be easy...
Comment 4 Bharath Acharya 2009-07-21 08:00:53 UTC
Reviewed and tested. Unused pieces.

And yes I'll look at the rest of the issues but as mentioned no GnomeDruid :) More than the issues, its Matthew's scare in comment #1 that keeps me away from it ;)
Comment 5 André Klapper 2009-07-21 08:38:36 UTC
Committed: 21950d46ca668d5039a5453e29d67b9a90a7e72f
Comment 6 Matthew Barnes 2009-07-21 12:08:46 UTC
Oh don't mind me.  There's even a tutorial to walk you through it:
http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkAssistant.html
Comment 7 André Klapper 2009-08-07 15:21:55 UTC
==========
WORK LEFT:
==========
./storage/migr-test.c:#include <libgnomeui/gnome-ui-init.h>
./storage/ximian-connector-setup.c:#include <libgnomeui/gnome-ui-init.h>
./storage/main.c:#include <libgnomeui/gnome-ui-init.h>
./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid.h>
./storage/exchange-autoconfig-wizard.c:#include <libgnomeui/gnome-druid-page-standard.h>

The first three issues should be really simple to fix.

And if abharath fixes the last two ones too we have somebody with enough knowledge to also remove gnome-druid from evolution. ;-)
Comment 8 Milan Crha 2009-08-19 10:08:41 UTC
Created attachment 141144 [details] [review]
proposed eex patch

for evolution-exchange;

It is not possible to leave the actual page after clicking Forward, thus this brings the failure page instead of an error dialog. This is for exchange-connector-setup process. I wasn't able to test it full, as mine test server is down at the moment.

The rest changes should work fine, I hope.
Comment 9 Bharath Acharya 2009-08-19 10:56:25 UTC
Awesome. Patch looks good to commit. Thanks for fixing this up.
Comment 10 Akhil Laddha 2009-08-20 06:41:13 UTC
Patch seems to be doing good .. i haven't seen any regression in half an hr run.
Comment 11 Milan Crha 2009-08-20 10:23:29 UTC
With Akhil's little bit more testing we found that the assistant_apply_cb may not contain the gtk_widget_destroy, it's handled in the close signal. Thus removed that. Otherwise patch kept as is. Enjoy.

Created commit a0ba3a0 in eex master (2.29.1+)
Comment 12 Claude Paroz 2009-08-24 10:04:40 UTC
Please could you mark for translation the following string:

+ w = gtk_check_button_new_with_label ("Make this my default account");
Comment 13 André Klapper 2009-08-24 10:35:40 UTC
Also, is there a reason that string does not have a mnemonic?
Comment 14 Milan Crha 2009-08-24 10:37:25 UTC
(In reply to comment #12)
> Please could you mark for translation the following string:
> 
> + w = gtk_check_button_new_with_label ("Make this my default account");

Sure, thanks for the review.

Created commit 8887a74 in eex master (2.29.1+)

(In reply to comment #13)
> Also, is there a reason that string does not have a mnemonic?

I do not know, I kept it as it was.
Comment 15 André Klapper 2009-08-24 10:41:16 UTC
Filed bug 592875.