After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580812 - missing libgnomeui dependency in libpanelappletmm
missing libgnomeui dependency in libpanelappletmm
Status: RESOLVED FIXED
Product: gnomemm
Classification: Deprecated
Component: libpanelappletmm
2.24
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2009-04-29 21:22 UTC by Frederic Peters
Modified: 2009-05-16 19:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
add dependency on libgnomeui (846 bytes, patch)
2009-04-29 21:23 UTC, Frederic Peters
committed Details | Review

Description Frederic Peters 2009-04-29 21:22:25 UTC
init.cc:29:19: error: gnome.h: No such file or directory
init.cc: In function ‘void Gnome::Panel::init(const Glib::ustring&, const Glib::ustring&, int, char**)’:
init.cc:41: error: ‘LIBGNOMEUI_MODULE’ was not declared in this scope
init.cc:41: error: ‘GNOME_CLIENT_PARAM_SM_CONNECT’ was not declared in this scope
make[4]: *** [init.lo] Erreur 1

This is because it looks for "gnome.h" from libgnomeui, without requesting that library in the configure script.
Comment 1 Frederic Peters 2009-04-29 21:23:34 UTC
Created attachment 133610 [details] [review]
add dependency on libgnomeui
Comment 2 Murray Cumming 2009-05-01 12:11:16 UTC
Feel free to commit, though it would be nice if we could avoid this dependency somehow.
Comment 3 Frederic Peters 2009-05-01 12:44:55 UTC
Agree, it would certainly be possible to replace the gnome_program_init() call with gtk_init() and bonobo_init(), just like it is done in PANEL_APPLET_BONOBO_FACTORY.

commit 3bc87f8d8647e8076fce7ab24f7fafecd294e66a
Author: Frederic Peters <fpeters@0d.be>
Date:   Fri May 1 14:37:35 2009 +0200

    declare dependency on libgnomeui
    
    It is required in order to pass LIBGNOMEUI_MODULE to gnome_program_init.
    (GNOME #580812)
Comment 4 Hubert Figuiere (:hub) 2009-05-01 17:08:36 UTC
(In reply to comment #2)
> Feel free to commit, though it would be nice if we could avoid this dependency
> somehow.
> 

The dependency was implicit before, but the panel dropped it. We can see if we can remove it for 2.28. 
Comment 5 Hubert Figuiere (:hub) 2009-05-01 23:28:24 UTC
While Fred patch fixes the build, the best is to actually get rid of the dependency altogether.

I'll cook up a fix for that.
Comment 6 Hubert Figuiere (:hub) 2009-05-16 19:44:51 UTC
fixed in master.