After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580771 - Video playback should have a fullscreen mode
Video playback should have a fullscreen mode
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
unspecified
Other All
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-29 16:06 UTC by Jonathan Tellier
Modified: 2009-05-12 17:23 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
[PATCH] Modifications to points addresses during first code review (29.68 KB, patch)
2009-05-11 14:41 UTC, Jonathan Tellier 		none Details | Review
Usability fix: The "Leave Fullscreen" button is now using the "gtk-leave-fullscreen" stock id instead of "gtk-fullscreen". (2.31 KB, patch)
2009-05-12 12:55 UTC, Jonathan Tellier 		none Details | Review
Fixed coding style (8.27 KB, patch)
2009-05-12 16:30 UTC, Jonathan Tellier 		none Details | Review

Description Jonathan Tellier 2009-04-29 16:06:19 UTC 
In a video conversation, it should be possible to go into fullscreen mode. When moving the mouse, a "Leave Fullscreen" button should appear, just like with the Totem Movie Player.
Comment 1 Jonathan Tellier 2009-05-08 14:33:18 UTC 
Branch which contains the implementation for this feature:
http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=commit;h=10686010ed50b5f39dc0abf000c66577dbff2ff9
Comment 2 Jonathan Tellier 2009-05-11 14:41:24 UTC 
Created attachment 134399 [details] [review]
[PATCH] Modifications to points addresses during first code review

 src/Makefile.am                       |    2 +
 src/empathy-call-window-fullscreen.c  |  276 +++++++++++++++++++++++++++++++
 src/empathy-call-window-fullscreen.h  |   73 +++++++++
 src/empathy-call-window-fullscreen.ui |   23 +++
 src/empathy-call-window.c             |  289 +++++++++++++++++++++++++++++++--
 src/empathy-call-window.ui            |   12 ++
 6 files changed, 662 insertions(+), 13 deletions(-)
Comment 3 Jonathan Tellier 2009-05-12 12:55:40 UTC 
Created attachment 134496 [details] [review]
Usability fix: The "Leave Fullscreen" button is now using the "gtk-leave-fullscreen" stock id instead of "gtk-fullscreen".
Comment 4 Jonathan Tellier 2009-05-12 16:30:16 UTC 
Created attachment 134511 [details] [review]
Fixed coding style
Comment 5 Guillaume Desmottes 2009-05-12 17:23:52 UTC 
I merged the branch to master. Thanks a lot for your contribution!