After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580654 - don't die on missing project media, allow locating it
don't die on missing project media, allow locating it
Status: VERIFIED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal blocker
: 0.13.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-28 21:19 UTC by Jean-François Fortin Tam
Modified: 2009-05-19 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-04-28 21:19:35 UTC
Loading a project without all the media files that was initially used in it is currently impossible. PiTiVi shows an unhelpful generic error about the fact that the project "couldn't be loaded", which doesn't hint that there is missing media.

What should happen instead:
- provide a more informative error dialog
- list the missing media files
- allow...
a) locating them automatically (locate? gnome-search-tool?) 
b) locating them manually (ask the user to "drag and drop files over their missing counterparts in the list or drag and drop the new folder containing the files")
c) ignoring the missing files temporarily and treat them as "missing" in the project (with questionmarks and "blank" clips?), allowing them to be replaced at another time (prompt the user again on next project load)

C would be similar to the concept of proxy editing and may require a special UI to allow swapping a clip by another manually.
Comment 1 Edward Hervey 2009-05-05 10:07:08 UTC
The Formatter API provides a way to give location of new files.

There's two things missing:
* implementing Formatter.addMapping (which stores a mapping of old directory to new directory)
* connecting to the 'missing-uri' signal in the UI
* calling addMapping when the user has given some feedback
Comment 2 Edward Hervey 2009-05-19 06:53:58 UTC
I implement Formatter.addMapping() yesterday. The rest is to connect the UI and call addMapping()

commit eb98fa65a1e52ba60a336bed8d17256f5dbf816c
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon May 18 21:15:38 2009 +0200

    Formatter: Add minimalistic support for moved file mapping.
    
    Requires implementation in the UI.
    
    The idea is that when a file has moved, Formatter will emit the
    'missing-uri' signal.
    Within that callback, the application should:
    * ask the user for the new location
    * call Formatter.addMapping()
    
    Hopefully... if files have moved for a project, they most likely
    have all moved in the same fashion, so this signal should only be
    emitted once.

Comment 3 Edward Hervey 2009-05-19 18:48:17 UTC
commit 876d8d92959e2903d8fd74e6f4ecd084b695601b
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue May 19 20:45:02 2009 +0200

    MissingURIDialog: Don't forget to unquote the URI. Finishes fixing #580654

commit 681d6e01b1591381e02a186b7d731867820b05eb
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue May 19 20:41:14 2009 +0200

    Formatter: Make mapping system a bit more resilient.
    
    I have to disable the test for the time being since it will
    actually check to see if the uri is accessible.

commit a465b19e592e1e8678e007c7ccb6ab6a6051db04
Author: Brandon Lewis <brandon_lewis@berkeley.edu>
Date:   Tue May 19 00:22:30 2009 -0700

    Application: forward missing-uri signal from formatter. Partially fixes #580654