Bug 580594 – gedit crashed with SIGSEGV in g_cclosure_marshal_VOID__OBJECT()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 580594 - gedit crashed with SIGSEGV in g_cclosure_marshal_VOID__OBJECT()


Summary:	gedit crashed with SIGSEGV in g_cclosure_marshal_VOID__OBJECT()


Status:	RESOLVED FIXED

Product:	gedit
Classification:	Applications
Component:	general
Version:	2.26.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Gedit maintainers
QA Contact:	Gedit maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-04-28 12:34 UTC by Pedro Villavicencio
Modified:	2009-05-01 19:20 UTC

See Also:
GNOME target:	---
GNOME version:	2.25/2.26

Attachments
patch (620 bytes, patch) 2009-05-01 19:20 UTC, Paolo Borelli	committed	Details \| Review

Description Pedro Villavicencio 2009-04-28 12:34:13 UTC

this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/gedit/+bug/368495

"I had one gedit window opened on the current desktop (with multiple tabs), and then in a console went to edit another file: $ gedit myfile.txt

Expected result: The gedit window should open a new tab with the file (as it usually does)

Actual Result: The console returned, but gedit went non-responsive and crashed (the new file never appeared in the window)."

".

+ Trace 214894

Thread 1 (process 3960)

#0 tab_added_cb
at gedit-drawspaces-plugin.c line 257
#1 IA__g_cclosure_marshal_VOID__OBJECT
at /build/buildd/glib2.0-2.20.1/gobject/gmarshal.c line 636
#2 IA__g_closure_invoke
at /build/buildd/glib2.0-2.20.1/gobject/gclosure.c line 767
#3 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.20.1/gobject/gsignal.c line 3247
#4 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.20.1/gobject/gsignal.c line 2980
#5 IA__g_signal_emit
at /build/buildd/glib2.0-2.20.1/gobject/gsignal.c line 3037
#6 notebook_tab_added
at gedit-window.c line 3171
#7 IA__g_cclosure_marshal_VOID__OBJECT
at /build/buildd/glib2.0-2.20.1/gobject/gmarshal.c line 636
#8 IA__g_closure_invoke
at /build/buildd/glib2.0-2.20.1/gobject/gclosure.c line 767
#9 signal_emit_unlocked_R
at /build/buildd/glib2.0-2.20.1/gobject/gsignal.c line 3247
#10 IA__g_signal_emit_valist
at /build/buildd/glib2.0-2.20.1/gobject/gsignal.c line 2980
#11 IA__g_signal_emit
at /build/buildd/glib2.0-2.20.1/gobject/gsignal.c line 3037
#12 gedit_notebook_add_tab
at gedit-notebook.c line 962
#13 gedit_window_create_tab_from_uri
at gedit-window.c line 3989
#14 load_file_list
at gedit-commands-file.c line 228
#15 on_message_received
at gedit.c line 329
#16 server_cb
at bacon-message-connection.c line 171
#17 g_io_unix_dispatch
at /build/buildd/glib2.0-2.20.1/glib/giounix.c line 162
#18 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.20.1/glib/gmain.c line 1814
#19 g_main_context_iterate
at /build/buildd/glib2.0-2.20.1/glib/gmain.c line 2448
#20 IA__g_main_loop_run
at /build/buildd/glib2.0-2.20.1/glib/gmain.c line 2656
#21 IA__gtk_main
at /build/buildd/gtk+2.0-2.16.1/gtk/gtkmain.c line 1205
#22 main
at gedit.c line 679

Comment 1 Paolo Borelli 2009-05-01 09:50:59 UTC

I managed to reproduce this: you have to deactivate and reactivate the drawspaces plugins and then open a new doc.

The crash is due to the fact that plugin->priv is null, (plugin has a refcount = 0, in other words has been finalized). I am not sure how's that happening though :(

Comment 2 Paolo Borelli 2009-05-01 19:20:33 UTC

Created attachment 133752 [details] [review]
patch

This patch should fix the issue. I committed it.

Comment 3 Paolo Borelli 2009-05-01 19:20:59 UTC

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.