After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580557 - Resync with libegg to remove deprecated GTK+ symbols
Resync with libegg to remove deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 610515
Blocks: 585692
 
 
Reported: 2009-04-28 08:04 UTC by Thomas Andersen
Modified: 2010-08-30 19:43 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Substitute gtk_button_pressed() and gtk_button_released() (2.89 KB, patch)
2010-01-09 02:33 UTC, Javier Jardón (IRC: jjardon)
rejected Details | Review
lib/egg: update scripts (2.08 KB, patch)
2010-08-30 18:26 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review
lib/egg: update to libegg master (38.13 KB, patch)
2010-08-30 18:26 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
lib/egg: update to libegg master (39.91 KB, patch)
2010-08-30 19:37 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review

Description Thomas Andersen 2009-04-28 08:04:02 UTC
Epiphany uses the deprecated gtk_widget_get_action in copy-pasted code from ligegg:

lib/egg/egg-editable-toolbar.c:203: action = gtk_widget_get_action (widget);
lib/egg/egg-editable-toolbar.c:229: action = gtk_widget_get_action (widget);
lib/egg/egg-editable-toolbar.c:500: GtkAction *action = gtk_widget_get_action (GTK_WIDGET (item));

The replacement gtk_activatable_get_related_action requires gtk 2.16 and libegg has added a check to use it if the available gtk version is high enough.

You should resync with libegg to get that code. The relevant commit it here:
http://git.gnome.org/cgit/libegg/commit/?id=3262b337f4527d0397032a6094de7b0c9e4ad3a5
Comment 1 André Klapper 2009-04-28 08:27:49 UTC
Heh. Also talked about this with Xan on IRC two days ago.
Comment 2 Xan Lopez 2009-04-28 08:37:33 UTC
Done in commit dcae8dfd69b1052907b94fc300537a20999938dc, thanks.
Comment 3 Javier Jardón (IRC: jjardon) 2010-01-09 02:33:43 UTC
Created attachment 151080 [details] [review]
Substitute gtk_button_pressed() and gtk_button_released()
Comment 4 Javier Jardón (IRC: jjardon) 2010-01-09 02:34:55 UTC
Sorry, I reopened this bug because epiphany has some newly deprecated symbols
Comment 5 Xan Lopez 2010-01-09 15:01:30 UTC
(In reply to comment #3)
> Created an attachment (id=151080) [details] [review]
> Substitute gtk_button_pressed() and gtk_button_released()

This patch is wrong (I should know, I committed something identical just to find it was broken). Those functions only get you the *visual effect*  a press/release, which is what epiphany needs, not the actual event (and btw, the event is missing in the signal emission). If you feed an event you'll get epiphany in an infinite loop, since this is being done as the result of a press/release event too.

The context is that we want to do actions on middle click on the toolbar buttons, but GtkButton does not react to middle click, so we catch the button-{press,release}-events manually and then fake the visual effect by calling those functions. I guess the good fix would be changing GtkButton to react to the middle button.
Comment 6 André Klapper 2010-05-08 15:56:13 UTC
Any plans to fix this / update the patch?
Comment 7 André Klapper 2010-05-29 10:20:50 UTC
Any plans to fix this / update the patch?
Comment 8 André Klapper 2010-06-20 10:23:57 UTC
Can this please be handled this week?
It is planned to ship GNOME 2.31.4 with gtk 2.90 hence it is required to fix / work around this.
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 07:24:22 UTC
Our copy of libegg needs an update again. I'll give it a look soonish.
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 18:26:03 UTC
Created attachment 169111 [details] [review]
lib/egg: update scripts

Bug #580557
Comment 11 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 18:26:07 UTC
Created attachment 169112 [details] [review]
lib/egg: update to libegg master

Bug #580557
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 19:37:06 UTC
Created attachment 169119 [details] [review]
lib/egg: update to libegg master

I just committed two more fixes to libegg master. This new patch includes them.
Comment 13 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 19:43:14 UTC
I think we have another bug for the pressed/released issue. I'll open a bug for
it otherwise. This is already a bit polluted.

Attachment 169111 [details] pushed as 333aeb8 - lib/egg: update scripts
Attachment 169119 [details] pushed as 6316dcb - lib/egg: update to libegg master