After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580296 - Segfault during documentation generation
Segfault during documentation generation
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
0.7.x
Other Linux
: Normal major
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 580377 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-26 14:30 UTC by J.H.M. Dassen (Ray)
Modified: 2009-05-11 05:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes the build issue (3.05 KB, patch)
2009-04-26 14:37 UTC, Jean Bréfort
committed Details | Review

Description J.H.M. Dassen (Ray) 2009-04-26 14:30:23 UTC
Version 0.7.5

15:57 <@JHM> goffice 0.7.5 is not making me happy.
15:59 <@JHM> On i386 (well, i386 chroot on amd64), I get segfaults from
             goffice-0.8-scan .
15:59 <@JHM> goffice-0.8-scan.c:129 is "object_types[i++] = go_conf_get_type
             ();"
16:00 <@JHM> This results in go_conf_get_type being called with bogus values,
16:00 <@JHM> thus calling get_schema with node being NULL or something invalid,
16:01 <@JHM> thus segfaulting when node is dereferenced in get_schema.
16:01 <@JHM> The node == NULL case is easy to fix,
16:01 <@JHM> but with an optimised (-O2) build, node is invalid rather than
             NULL.
16:10 < jean> hmm, the go_conf code is not that new
16:18 < jean> ah, I see, we should probably rename it go_conf_get_key_type or so
16:18 < jean> strange this did not appeared earlier
16:19 < jean> go_conf_get_node_type is better
16:23 <@JHM> Sounds fine to me - this should prevent gtk-doc from trying to 
             scan it.
16:25 < jean> please file a bug report

This is what this looks like (with the ...docs/reference/goffice-0.8-scan script instrumented to call gdb):
(gdb) where
  • #0 go_conf_get_type
    at ../../../goffice/app/go-conf-gconf.c line 283
  • #1 main
    at goffice-0.8-scan.c line 129

Comment 1 Jean Bréfort 2009-04-26 14:37:16 UTC
Created attachment 133332 [details] [review]
fixes the build issue

It should not break anything since it seems that this function was just used internally.
Comment 2 Jean Bréfort 2009-04-26 14:48:16 UTC
Fixed.
Comment 3 Jean Bréfort 2009-04-27 06:10:46 UTC
Used go_conf_node_get_key_type finally.
Comment 4 Götz Waschk 2009-05-11 05:28:53 UTC
*** Bug 580377 has been marked as a duplicate of this bug. ***