GNOME Bugzilla – Bug 580144
emit notify::internal-ssrc when there is a ssrc collision
Last modified: 2009-04-27 09:14:11 UTC
Attaching a patch that adds a couple calls to g_object_notify(). Also, while I'm at it, downgrade the message when there is a ssrc change in the buffer from WARNING to LOG because pad alloc is not implemented in any of the RTP components, so there is no way to notify upstream elements about collisions.
Created attachment 133265 [details] [review] rtpsession: Emit notify when the internal-ssrc property changes
Created attachment 133266 [details] [review] rtpsource: Downgrade warning on ssrc update to LOG evel Since neither rtpmanager nor any of the payloaders properly implement pad allocation, there is no way for rtpmanager to update them if there is an SSRC collision. So the warning is emitted all the time and it is confusing.
commit cc51f90c1a74bc8bb61ff1121720d1ea36f074e5 Author: Olivier Crete <olivier.crete@collabora.co.uk> Date: Mon Apr 27 11:09:08 2009 +0200 rtpsouce: make WARNING into LOG Since neither rtpmanager nor any of the payloaders properly implement pad allocation, there is no way for the rtpmanager to inform downstream elements of the new SSRC if there is an SSRC collision. So the warning is emitted all the time and it is confusing. Fixes #580144 commit bf3ea86c2ffa74c064a26a134d7477560f54b6c3 Author: Olivier Crete <olivier.crete@collabora.co.uk> Date: Mon Apr 27 11:06:01 2009 +0200 rtpsession: notify when SSRC changes Emit a g_object_notify when the SSRc changes because of a collision. Fixes #580144