After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580134 - Displays empty bubbles for messages containing <
Displays empty bubbles for messages containing <
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-24 16:04 UTC by Will Thompson
Modified: 2009-08-06 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Escape markup in notification bubbles. (2.30 KB, patch)
2009-08-04 21:18 UTC, Will Thompson
none Details | Review
Escape markup in notifications and icon tooltip (2.46 KB, patch)
2009-08-04 21:39 UTC, Will Thompson
accepted-commit_now Details | Review
Don't try to free NULL pixbufs. (3.23 KB, patch)
2009-08-04 21:39 UTC, Will Thompson
accepted-commit_now Details | Review

Description Will Thompson 2009-04-24 16:04:10 UTC
When Rob pasted me some text from irssi, I got an empty notification bubble.

This seems to be because it contained "<". I think Empathy should be escaping markup before sending it to libnotify.
Comment 1 Pierre-Luc Beaudoin 2009-06-19 02:30:38 UTC
Should be easy to fix, marking as gnome-love.
Comment 2 Baptiste Mille-Mathias 2009-06-19 20:44:37 UTC
I don't see the problem, however ubuntu uses notify-osd, could it be a problem with the notification system?
Comment 3 Baptiste Mille-Mathias 2009-07-25 17:27:27 UTC
Will, could you provide more information about your system (notification version, distro version) and does this problem still appear?
Comment 4 Will Thompson 2009-08-04 21:18:19 UTC
Created attachment 139908 [details] [review]
Escape markup in notification bubbles.

7730ffd fixed this for the notifications that are produced by the chat
window, but not for the ones produced by the status icon. Why these are
separate code paths eludes me.
Comment 5 Will Thompson 2009-08-04 21:27:30 UTC
Whoops. My initial patch fixing this leaked the escaped strings. I've also noticed that the code which doesn't try to set a NULL pixbuf as the notification's icon still tries to unref the pixbuf, but g_object_unref (NULL); criticals. I'll fix that too...
Comment 6 Will Thompson 2009-08-04 21:39:14 UTC
My branch at http://git.collabora.co.uk/?p=user/wjt/empathy.git;a=shortlog;h=refs/heads/escape-notifications fixes this, and also fixes the NULL-unref I noticed. Patches to follow...
Comment 7 Will Thompson 2009-08-04 21:39:21 UTC
Created attachment 139910 [details] [review]
Escape markup in notifications and icon tooltip

7730ffd fixed this for the notifications that are produced by the chat
window, but not for the ones produced by the status icon. Why these are
separate code paths eludes me.
Comment 8 Will Thompson 2009-08-04 21:39:23 UTC
Created attachment 139911 [details] [review]
Don't try to free NULL pixbufs.

It's all very well to ensure that we don't pass a NULL pixbuf to
libnotify, but we shouldn't then try to g_object_unref () the pointer
without checking it's not NULL.
Comment 9 Guillaume Desmottes 2009-08-06 11:57:57 UTC
Looks good. Please merge. Thanks for the patches!
Comment 10 Will Thompson 2009-08-06 13:31:06 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.