After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579455 - gst.TIME_ARGS doesn't validate input
gst.TIME_ARGS doesn't validate input
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal blocker
: 0.10.15
Assigned To: Jan Schmidt
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-18 21:30 UTC by Thomas Vander Stichele
Modified: 2009-04-23 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Vander Stichele 2009-04-18 21:30:46 UTC 
gst.TIME_ARGS(None) will for example trigger a PyErr that doesn't get caught, and then shows up instead of some other exception in the wrong place.
Comment 1 Thomas Vander Stichele 2009-04-18 21:59:01 UTC 
http://thomas.apestaart.org/cgit/gst-python/log/?h=bz-579455

This branch fixes it and adds tests.
Comment 2 Jan Schmidt 2009-04-19 02:07:28 UTC 
This patch referencing technique needs some polish.

I can see in commit http://thomas.apestaart.org/cgit/gst-python/commit/?h=bz-579455&id=6843186d3189185f088499411ac3cd4a252d7423 where it adds the unit test, but I can't see where the commit that validates the input is.
Comment 3 Edward Hervey 2009-04-19 11:44:10 UTC 
Can't see the proper commit either. Only the unit_test one.

Thomas, can you reply when your repo is updated with the proper patch ?
Comment 4 Jan Schmidt 2009-04-21 20:30:14 UTC 
Heya Thomas, in the absence of any update, I'm going to call this not a blocker for this release....
Comment 5 Thomas Vander Stichele 2009-04-22 22:38:50 UTC 
Not sure how you don't see it, it's right there at the top of that branch:

http://thomas.apestaart.org/cgit/gst-python/commit/?h=bz-579455&id=02da59c7c8829a996c25843f2119d6e19165f1e6
Comment 6 Jan Schmidt 2009-04-22 23:02:50 UTC 
That commit was not there the other day :)
Comment 7 Edward Hervey 2009-04-23 15:10:13 UTC 
commit 12a210c6137aaf2958db8f0a570ef00711f55ffa
Author: Thomas Vander Stichele <thomas (at) apestaart (dot) org>
Date:   Sat Apr 18 23:52:08 2009 +0200

    TIME_ARGS: Catch bad input. Fixes #579455